-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DG: Add Tags feature #192
DG: Add Tags feature #192
Conversation
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
=========================================
Coverage 75.67% 75.67%
Complexity 586 586
=========================================
Files 96 96
Lines 1768 1768
Branches 183 183
=========================================
Hits 1338 1338
Misses 345 345
Partials 85 85 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!!!!
Update: Change the Module --> Tag association from composition to navigability as discussed. Yes I made a typo in the commit LOL so I hope this clears confusion |
Model
component to includeUniqueTagMap
(includes updated diagram)View here: https://silvernitro.github.io/tp/DeveloperGuide.html#tags-feature
Closes #183 & #186