Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG: Add Tags feature #192

Merged

Conversation

Silvernitro
Copy link

@Silvernitro Silvernitro commented Nov 6, 2020

  • Update Model component to include UniqueTagMap (includes updated diagram)
  • Add Tags feature
    • Explain our implementation of tags
    • What happens when a module is added (includes diagram)
    • What happens when module is deleted (includes diagram)
    • Editing a module

View here: https://silvernitro.github.io/tp/DeveloperGuide.html#tags-feature

Closes #183 & #186

@Silvernitro Silvernitro added documentation Improvements or additions to documentation type.Task priority.Medium labels Nov 6, 2020
@Silvernitro Silvernitro added this to the v1.4 milestone Nov 6, 2020
@Silvernitro Silvernitro requested a review from a team November 6, 2020 15:30
@Silvernitro Silvernitro self-assigned this Nov 6, 2020
@codecov-io
Copy link

codecov-io commented Nov 6, 2020

Codecov Report

Merging #192 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #192   +/-   ##
=========================================
  Coverage     75.67%   75.67%           
  Complexity      586      586           
=========================================
  Files            96       96           
  Lines          1768     1768           
  Branches        183      183           
=========================================
  Hits           1338     1338           
  Misses          345      345           
  Partials         85       85           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ab8d04...0c53967. Read the comment docs.

Copy link

@yan-soon yan-soon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!!

@Silvernitro
Copy link
Author

Update: Change the Module --> Tag association from composition to navigability as discussed. Yes I made a typo in the commit LOL so I hope this clears confusion

@Silvernitro Silvernitro merged commit 5a05e0e into AY2021S1-CS2103T-T09-1:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority.Medium type.Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Model Component with new tags
4 participants