Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DG and UG - UI component and Find feature #62

Merged
merged 8 commits into from
Oct 19, 2020

Conversation

mhdsyfq77
Copy link

Changes to DG:

  • Changed UI class diagram and replaced png image
  • Updated UI links and descriptions
  • Created Find command sequence diagram
  • Add find sequence diagram image
  • List out find command behaviour during execution

Changes to UG:

  • Include Find feature
  • Removed Save feature
  • A small nitpick i.e. {module description} ➡️ {module code}

Resolves #60 and resolves #61

@mhdsyfq77 mhdsyfq77 added documentation Improvements or additions to documentation type.Task priority.Medium labels Oct 17, 2020
@mhdsyfq77 mhdsyfq77 self-assigned this Oct 17, 2020
@codecov-io
Copy link

codecov-io commented Oct 17, 2020

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #62   +/-   ##
=========================================
  Coverage     73.31%   73.31%           
  Complexity      424      424           
=========================================
  Files            76       76           
  Lines          1274     1274           
  Branches        123      123           
=========================================
  Hits            934      934           
  Misses          302      302           
  Partials         38       38           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d94aac...2d5489c. Read the comment docs.

@mhdsyfq77 mhdsyfq77 requested review from a team and removed request for Silvernitro, shaokiat and yan-soon October 17, 2020 11:19
Copy link

@Silvernitro Silvernitro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one small comment/question

docs/UserGuide.md Outdated Show resolved Hide resolved
# Conflicts:
#	docs/DeveloperGuide.md
@mhdsyfq77 mhdsyfq77 merged commit 675d961 into AY2021S1-CS2103T-T09-1:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority.Medium type.Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Find command implementation in DG and update UG Update UI component in DG
4 participants