-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update feature descriptions and images for UG, Add Intro for DG and update HelpCommand #70
Update feature descriptions and images for UG, Add Intro for DG and update HelpCommand #70
Conversation
…pdate HelpCommand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM yan nice job 👍🏽 just some slight nits if you dont mind, just suggestions - not sure if they're 100% right though, im not silvernitro 😝
docs/UserGuide.md
Outdated
Description: | ||
|
||
* Adds any Module of choice into the list of Current Modules in GradPad. | ||
|
||
* User can add any module by specifying their desired Module Code (eg. CS1231), | ||
Modular Credits (eg. 4), and Tags (eg. Core) along with the `add` command, in their | ||
input. | ||
|
||
* Module Code and Modular Credit fields are compulsory inputs but Tag fields are optional. | ||
Multiple Tags are allowed per module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe can include that the add command prevents duplicate modules from being created? actually right.... as of now our application allows duplicates if they are not completely equal, should we address that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion! Added in
docs/UserGuide.md
Outdated
|
||
* Edits the module details of a module that has already been added to GradPad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor nit: perhaps "Edit the details of a module...." would be better? 😅
oh! and also, i thought we were changing edit to edit {module code} instead of edit {index}? 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the structuring! For the edit {index}, I decided to keep it as {index} for now to match the expected outcome images! I can change it accordingly once we have updated our code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice noted!
Exits the program. There is no auto-save upon exit. | ||
Description: | ||
|
||
* Exits GradPad. All changes made while on GradPad will be saved automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think might not be necessary to mention the save part cause if im not wrong the exit command doesn't do a final save before exiting 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too sure as well, was kinda going for the notion that saving would be done automatically throughout usage of the app, cause I realise we didnt mention anything about saving throughout, and I thought people might think of saving when they think of exiting HAHAHA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HAHAHAHA true true true...... then either we stick with this or we must include the 'auto-save' in the other features ah
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=========================================
Coverage 75.00% 75.00%
Complexity 423 423
=========================================
Files 75 75
Lines 1244 1244
Branches 122 122
=========================================
Hits 933 933
Misses 273 273
Partials 38 38
Continue to review full report at Codecov.
|
UG
DG
HelpCommand