Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feature descriptions and images for UG, Add Intro for DG and update HelpCommand #70

Merged
merged 8 commits into from
Oct 20, 2020

Conversation

yan-soon
Copy link

UG

  • Updated feature descriptions to be more descriptive and clear
  • Updated images under "Expected Outcome" to showcase updated GUI
  • Updated feature notes

DG

  • Added an "Introduction" section talking about GradPad
  • Added an "About this Guide" section talking about the purpose of the DG
  • Removed "Data Archiving" portion under "Proposed Implementation"

HelpCommand

  • Updated "help" command to showcase list of commands and functions instead of showing a hyperlink to our UG.
  • Did not change initial design of the HelpCommand and CommandResult class, just in case we want to showcase a list of commands + a hyperlink to our UG in the future.

@yan-soon yan-soon added documentation Improvements or additions to documentation type.Task priority.Medium labels Oct 19, 2020
@yan-soon yan-soon added this to the v1.3 milestone Oct 19, 2020
@yan-soon yan-soon requested a review from a team October 19, 2020 17:17
@yan-soon yan-soon self-assigned this Oct 19, 2020
Copy link

@mhdsyfq77 mhdsyfq77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM yan nice job 👍🏽 just some slight nits if you dont mind, just suggestions - not sure if they're 100% right though, im not silvernitro 😝

Comment on lines 123 to 132
Description:

* Adds any Module of choice into the list of Current Modules in GradPad.

* User can add any module by specifying their desired Module Code (eg. CS1231),
Modular Credits (eg. 4), and Tags (eg. Core) along with the `add` command, in their
input.

* Module Code and Modular Credit fields are compulsory inputs but Tag fields are optional.
Multiple Tags are allowed per module.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe can include that the add command prevents duplicate modules from being created? actually right.... as of now our application allows duplicates if they are not completely equal, should we address that?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion! Added in


* Edits the module details of a module that has already been added to GradPad.
Copy link

@mhdsyfq77 mhdsyfq77 Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor nit: perhaps "Edit the details of a module...." would be better? 😅

oh! and also, i thought we were changing edit to edit {module code} instead of edit {index}? 😕

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the structuring! For the edit {index}, I decided to keep it as {index} for now to match the expected outcome images! I can change it accordingly once we have updated our code

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice noted!

Exits the program. There is no auto-save upon exit.
Description:

* Exits GradPad. All changes made while on GradPad will be saved automatically.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think might not be necessary to mention the save part cause if im not wrong the exit command doesn't do a final save before exiting 😄

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too sure as well, was kinda going for the notion that saving would be done automatically throughout usage of the app, cause I realise we didnt mention anything about saving throughout, and I thought people might think of saving when they think of exiting HAHAHA

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HAHAHAHA true true true...... then either we stick with this or we must include the 'auto-save' in the other features ah

@codecov-io
Copy link

codecov-io commented Oct 20, 2020

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #70   +/-   ##
=========================================
  Coverage     75.00%   75.00%           
  Complexity      423      423           
=========================================
  Files            75       75           
  Lines          1244     1244           
  Branches        122      122           
=========================================
  Hits            933      933           
  Misses          273      273           
  Partials         38       38           
Impacted Files Coverage Δ Complexity Δ
...java/seedu/address/logic/commands/HelpCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f3032...9453e49. Read the comment docs.

@yan-soon yan-soon merged commit 7ca2fbc into AY2021S1-CS2103T-T09-1:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority.Medium type.Task
Projects
None yet
5 participants