Change find command to allow better searches #77
Conversation
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
============================================
- Coverage 74.46% 74.42% -0.05%
Complexity 424 424
============================================
Files 75 75
Lines 1253 1251 -2
Branches 125 125
============================================
- Hits 933 931 -2
Misses 273 273
Partials 47 47
Continue to review full report at Codecov.
|
| @@ -20,22 +19,20 @@ | |||
| * containsWordIgnoreCase("ABc def", "DEF") == true | |||
| * - middle word in sentence | ||
| * - matches first word in ModuleCode | ||
| * - last word in ModuleCode | ||
| * - middle word in ModuleCode |
There was a problem hiding this comment.
Should we add "matches part of any word in ModuleCode" too? Since now we support it
| * - any word | ||
| * - word containing symbols/numbers | ||
| * - word with leading/trailing spaces | ||
| * | ||
| * Valid equivalence partitions for sentence: | ||
| * Valid equivalence partitions for ModuleCode: | ||
| * - empty string | ||
| * - one word | ||
| * - multiple words |
There was a problem hiding this comment.
Do you think we should remove "multiple words" ah? I feel like it might be an irrelevant equivalence class now that we use a .contains() check
Removing it will also match the new test cases below since we're removing the old tests involving multiple words
| * - any word | ||
| * - word containing symbols/numbers | ||
| * - word with leading/trailing spaces | ||
| * | ||
| * Valid equivalence partitions for sentence: | ||
| * Valid equivalence partitions for ModuleCode: | ||
| * - empty string | ||
| * - one word | ||
| * - multiple words |
| * - query word matches part of a sentence word | ||
| * - sentence word matches part of the query word | ||
| * - ModuleCode word matches part of the CharSequence |
There was a problem hiding this comment.
Is this part supposed to return true now? now that we changed the find command to .contains()
Minor nit:
ModuleCodeso that when user entersadd c/cs2103t cr/4, the module code displayed in the GUI would be displayed as "CS2103T", for standardisation purposesCloses #76