-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dg: manual testing #87
Update dg: manual testing #87
Conversation
# Conflicts: # docs/DeveloperGuide.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice stuff here bro 💯 I really like how comprehensive this is :D Just a smol typo nit and we're g2g!
docs/DeveloperGuide.md
Outdated
1. Test case: `help` | ||
Expected: Help page is displayed. | ||
|
||
1. Test case: `checkmc modules` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a typo for help modules
? LOL actually can't tell cos this is still a correct invalid command HAHA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ya its supposed to be help modules LOL cause its under "### Open Help Page". i'll fix it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor feedback, LGTM otherwise!
1. Test case: Click the "close" button (red button) at the top of the window.<br> | ||
Expected: The window closes immediately. | ||
|
||
1. Test case: `exit`<br> | ||
Expected: GUI shows a farewell message,"Exiting GradPad as requested ..." and delays for 1.5 seconds, after which the window closes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we currently have the 1.5 secs time delay implemented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not yet but im planning to implement it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay dope
docs/DeveloperGuide.md
Outdated
1. Test case: `add c/cs2100 cr/4 tag/hardestmoduleever`<br> | ||
Expected: Similar to previous. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can specify what Similar to previous means exactly?
docs/DeveloperGuide.md
Outdated
1. Deleting a module. | ||
1. Other invalid delete commands to try: `delete cs2103t 4`, `delete c/cs2103t`, `delete 1`<br> | ||
Expected: Similar to previous. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above
docs/DeveloperGuide.md
Outdated
1. Test case: `edit cs2103t cr/5`<br> | ||
Expected: Similar to previous. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above!
docs/DeveloperGuide.md
Outdated
1. Other invalid edit commands to try: `edit`, `edit cs2103t 2103 5`, `edit 1`<br> | ||
Expected: Similar to previous. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above!
|
||
1. _{ more test cases … }_ | ||
1. Other invalid delete commands to try: `search c/cs2103t`, `delete 1`<br> | ||
Expected: Similar to previous. | ||
|
||
### Saving data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think we can remove this line haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HAHAHAHA bro i just followed the given, not sure if correct syntax :') maybe i should just put the same line as the one above instead of putting "Similar to previous." 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya HAHAH i think that would be a lot clearer
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=========================================
Coverage 74.46% 74.46%
Complexity 424 424
=========================================
Files 75 75
Lines 1253 1253
Branches 125 125
=========================================
Hits 933 933
Misses 273 273
Partials 47 47 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #86