Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dg: manual testing #87

Merged

Conversation

mhdsyfq77
Copy link

  • Added manual testing to developer guide

Closes #86

@mhdsyfq77 mhdsyfq77 added documentation Improvements or additions to documentation priority.Medium labels Oct 21, 2020
@mhdsyfq77 mhdsyfq77 added this to the v1.3 milestone Oct 21, 2020
@mhdsyfq77 mhdsyfq77 requested a review from a team October 21, 2020 09:54
@mhdsyfq77 mhdsyfq77 self-assigned this Oct 21, 2020
Copy link

@Silvernitro Silvernitro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice stuff here bro 💯 I really like how comprehensive this is :D Just a smol typo nit and we're g2g!

1. Test case: `help`
Expected: Help page is displayed.

1. Test case: `checkmc modules`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a typo for help modules? LOL actually can't tell cos this is still a correct invalid command HAHA

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ya its supposed to be help modules LOL cause its under "### Open Help Page". i'll fix it!

Copy link

@yan-soon yan-soon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor feedback, LGTM otherwise!

Comment on lines +721 to +725
1. Test case: Click the "close" button (red button) at the top of the window.<br>
Expected: The window closes immediately.

1. Test case: `exit`<br>
Expected: GUI shows a farewell message,"Exiting GradPad as requested ..." and delays for 1.5 seconds, after which the window closes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we currently have the 1.5 secs time delay implemented?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet but im planning to implement it!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay dope

Comment on lines 738 to 739
1. Test case: `add c/cs2100 cr/4 tag/hardestmoduleever`<br>
Expected: Similar to previous.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can specify what Similar to previous means exactly?

Comment on lines 725 to 776
1. Deleting a module.
1. Other invalid delete commands to try: `delete cs2103t 4`, `delete c/cs2103t`, `delete 1`<br>
Expected: Similar to previous.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

Comment on lines 790 to 791
1. Test case: `edit cs2103t cr/5`<br>
Expected: Similar to previous.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above!

Comment on lines 808 to 809
1. Other invalid edit commands to try: `edit`, `edit cs2103t 2103 5`, `edit 1`<br>
Expected: Similar to previous.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above!


1. _{ more test cases …​ }_
1. Other invalid delete commands to try: `search c/cs2103t`, `delete 1`<br>
Expected: Similar to previous.

### Saving data

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think we can remove this line haha

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HAHAHAHA bro i just followed the given, not sure if correct syntax :') maybe i should just put the same line as the one above instead of putting "Similar to previous." 🤣

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya HAHAH i think that would be a lot clearer

@codecov-io
Copy link

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #87   +/-   ##
=========================================
  Coverage     74.46%   74.46%           
  Complexity      424      424           
=========================================
  Files            75       75           
  Lines          1253     1253           
  Branches        125      125           
=========================================
  Hits            933      933           
  Misses          273      273           
  Partials         47       47           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c23fe05...243a082. Read the comment docs.

Copy link

@yan-soon yan-soon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Silvernitro Silvernitro merged commit e8720e5 into AY2021S1-CS2103T-T09-1:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority.Medium type.Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update DG: add manual testing
5 participants