Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertions #92

Merged
merged 3 commits into from
Oct 21, 2020
Merged

Conversation

mhdsyfq77
Copy link

Added assertions to the following classes:

  • GuiSettings
  • LogsCenter
  • LogicManager
  • FindCommand
  • ModuleCodeContainsKeywordsPredicate

Resolves #91

@mhdsyfq77 mhdsyfq77 added this to the v1.3 milestone Oct 21, 2020
@mhdsyfq77 mhdsyfq77 requested a review from a team October 21, 2020 13:53
@mhdsyfq77 mhdsyfq77 self-assigned this Oct 21, 2020
Copy link

@Silvernitro Silvernitro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@yan-soon yan-soon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #92 into master will decrease coverage by 0.59%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
- Coverage     74.42%   73.83%   -0.60%     
- Complexity      424      428       +4     
============================================
  Files            75       75              
  Lines          1251     1261      +10     
  Branches        125      130       +5     
============================================
  Hits            931      931              
  Misses          273      273              
- Partials         47       57      +10     
Impacted Files Coverage Δ Complexity Δ
...n/java/seedu/address/commons/core/GuiSettings.java 62.06% <0.00%> (-7.17%) 6.00 <0.00> (+1.00) ⬇️
...in/java/seedu/address/commons/core/LogsCenter.java 76.31% <0.00%> (-2.07%) 10.00 <0.00> (ø)
...rc/main/java/seedu/address/logic/LogicManager.java 68.18% <0.00%> (-6.82%) 4.00 <0.00> (+1.00) ⬇️
...java/seedu/address/logic/commands/FindCommand.java 81.81% <0.00%> (-18.19%) 7.00 <0.00> (+1.00) ⬇️
...el/module/ModuleCodeContainsKeywordsPredicate.java 77.77% <0.00%> (-22.23%) 8.00 <0.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0d9c31...2b10576. Read the comment docs.

@yan-soon yan-soon merged commit 59b4c10 into AY2021S1-CS2103T-T09-1:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add assertions where relevant
5 participants