Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues found #187

Merged
merged 9 commits into from
Nov 4, 2020
Merged

Fix issues found #187

merged 9 commits into from
Nov 4, 2020

Conversation

nicholasyeo
Copy link

No description provided.

@nicholasyeo nicholasyeo added this to the v1.4 milestone Nov 4, 2020
@nicholasyeo nicholasyeo self-assigned this Nov 4, 2020
This was linked to issues Nov 4, 2020
[PE-D] Case sensetive when duplicate lesson is added #129
Closed
[PE-D] "lesson_delete" and " and "lesson_edit" index error message #131
Closed
[PE-D] No upper bound for unreasonable height limit #135
Closed
[PE-D] No upper bound for unreasonable weight limit #136
Closed
[PE-D] Infinity BMI with 0 as input value for height #137
Closed
[PE-D] No error message when incorrect command is entered for "height" and "weight" #138
Closed
[PE-D] Cannot see Friday on Timetable with the default resolution #144
Closed
[PE-D] lesson_edit index negative numbers #154
Closed
[PE-D] timetable_add_lesson return message #156
Closed
[PE-D] View of Timetable #162
Closed
khor-jingqian
khor-jingqian approved these changes Nov 4, 2020
View reviewed changes
Copy link

@khor-jingqian khor-jingqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgTM

@khor-jingqian khor-jingqian merged commit 3c9a0df into AY2021S1-CS2103T-T09-2:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khor-jingqian khor-jingqian khor-jingqian approved these changes

Assignees

@nicholasyeo nicholasyeo

Labels
None yet
Projects
None yet
Milestone
v1.4
2 participants
@nicholasyeo @khor-jingqian