Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D] Attraction opening hours opening time can be later than closing time #240

Closed
nus-pe-bot opened this issue Oct 30, 2020 · 2 comments · Fixed by #271
Closed

[PE-D] Attraction opening hours opening time can be later than closing time #240

nus-pe-bot opened this issue Oct 30, 2020 · 2 comments · Fixed by #271
Assignees
@yuxuanxc
Labels
documentation Improvements or additions to documentation
Milestone
v1.4

Comments

@nus-pe-bot
Copy link

image.png

It is currently possible to specify an opening time of an attraction to be earlier than its closing time. While not a huge bug, it may seem a little odd, such as in the attached screenshot.

Labels: severity.Low type.FunctionalityBug
original: shawn-nyk/ped#1
@yuxuanxc yuxuanxc self-assigned this Oct 31, 2020
@Robinho98
Copy link

Type a tip in UG that opening hours can be later than closing hour, cos of overnight attractions

@limkoonkiat
Copy link

Technically start time can be after end time if it is overnight (need specify in ug)

@limkoonkiat limkoonkiat added the documentation Improvements or additions to documentation label Oct 31, 2020
@limkoonkiat limkoonkiat added this to the v1.4 milestone Oct 31, 2020
@yuxuanxc yuxuanxc linked a pull request Nov 3, 2020 that will close this issue
Change java version from 11.0.1 to 8 #271
Merged
yuxuanxc added a commit to yuxuanxc/tp that referenced this issue Nov 4, 2020
@yuxuanxc
Add notes in User guide for Budget, Opening Hours (Issues AY2021S1-CS…
ec4e1a3 
…2103T-T09-3#222 and AY2021S1-CS2103T-T09-3#240)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuxuanxc yuxuanxc

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Change java version from 11.0.1 to 8 yuxuanxc/tp
4 participants
@nus-pe-bot @Robinho98 @yuxuanxc @limkoonkiat