Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-D] Day index out of bounds for edit-itinerary-attraction command seems to not throw an error #246

Closed
nus-pe-bot opened this issue Oct 30, 2020 · 0 comments · Fixed by #269
Assignees

Comments

@nus-pe-bot
Copy link

When the day index is out of bounds for edit-itinerary-attraction command, there seems to be no error thrown.

In the given screenshot, there are 381 days in the selected itinerary, so day/400 is out of bounds. But instead of throwing an error, when the command in the screenshot was executed, the previous display message continues to stay on in the result box and nothing happens in the app, instead of showing an error message to inform the user what went wrong.

image.png


Labels: severity.Low type.FunctionalityBug
original: shawn-nyk/ped#7

@peter-yeh peter-yeh self-assigned this Oct 31, 2020
peter-yeh added a commit to peter-yeh/tp that referenced this issue Nov 1, 2020
Invalid day will now throw error and highlight the command in red.

Closes AY2021S1-CS2103T-T09-3#237, AY2021S1-CS2103T-T09-3#246, AY2021S1-CS2103T-T09-3#236
@peter-yeh peter-yeh linked a pull request Nov 1, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants