Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branchv1.2 testing optional fields #99

Conversation

peter-yeh
Copy link

No description provided.

Test optional field description, opening hours, price range, rating.

Test Invalid field description, opening hours, price range, rating.
Fix wrong error message was thrown when invalid opening hours, price
range and rating was entered.
@peter-yeh
Copy link
Author

peter-yeh commented Oct 13, 2020

Merge this after Add itinerary #98 has merged

@limkoonkiat limkoonkiat added this to the v1.2 milestone Oct 14, 2020
@peter-yeh peter-yeh marked this pull request as ready for review October 14, 2020 12:28
@codecov-io
Copy link

Codecov Report

Merging #99 into master will increase coverage by 1.15%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #99      +/-   ##
============================================
+ Coverage     72.28%   73.44%   +1.15%     
- Complexity      485      494       +9     
============================================
  Files            78       78              
  Lines          1555     1555              
  Branches        192      192              
============================================
+ Hits           1124     1142      +18     
+ Misses          356      347       -9     
+ Partials         75       66       -9     
Impacted Files Coverage Δ Complexity Δ
...in/java/seedu/address/logic/parser/ParserUtil.java 95.45% <75.00%> (+12.12%) 25.00 <0.00> (+4.00)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <0.00%> (+27.77%) 13.00% <0.00%> (+5.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9de2e5...1e2a49d. Read the comment docs.

@peter-yeh peter-yeh merged commit 4d3e921 into AY2021S1-CS2103T-T09-3:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create test cases to test for optional fields Change error massage for opening hours error
4 participants