Phase management, transition handling, and command validation #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone, I added phase logic :o
Here are some new files:
I also augmented the
Command
class by adding anextPhase
attribute which letsPhaseManager
know what phase to transition (if any) to upon execution of the command. I also added aallowedPhases
hash set to let thePhaseManager
check whether a given command is permitted to execute in the current phase. If not, thenPhaseInvalidException
will be thrown that ideally bubbles up to the UI manager and alerts the user ^_^I updated
LogicManager
to contain the above checking and exception logic (no pun intended).Lastly, I have written a test
PhaseManagerTest
which as of now tests very little. Still figuring out how to mock aCommand
object so I can test for correct transitions and whether exceptions are thrown correctly. Maybe someone can point me in the right direction as I work on other features 🙏.