Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #197

Conversation

boundtotheearth
Copy link
Collaborator

@boundtotheearth boundtotheearth commented Oct 31, 2020

Create a generic UniqueItemList to replace UniqueDurationList and UniqueTrackedItemList
Refactor sort commands to work on the displayed list rather than the data inside the model
Fix Undo/Redo for find

@codecov-io
Copy link

Codecov Report

Merging #197 into master will decrease coverage by 0.11%.
The diff coverage is 70.46%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #197      +/-   ##
============================================
- Coverage     60.08%   59.96%   -0.12%     
+ Complexity      841      825      -16     
============================================
  Files           144      143       -1     
  Lines          3179     3105      -74     
  Branches        365      350      -15     
============================================
- Hits           1910     1862      -48     
+ Misses         1127     1105      -22     
+ Partials        142      138       -4     
Impacted Files Coverage Δ Complexity Δ
...edu/momentum/logic/commands/DeleteTaskCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...seedu/momentum/logic/commands/EditTaskCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...du/momentum/logic/commands/ProjectViewCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...eedu/momentum/logic/commands/StartTaskCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...seedu/momentum/logic/commands/StopTaskCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/momentum/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...c/main/java/seedu/momentum/model/project/Task.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/seedu/momentum/model/timer/WorkDuration.java 80.00% <0.00%> (ø) 11.00 <0.00> (ø)
.../momentum/storage/JsonSerializableProjectBook.java 100.00% <ø> (ø) 5.00 <0.00> (ø)
src/main/java/seedu/momentum/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcaf73f...4ad9d29. Read the comment docs.

@boundtotheearth boundtotheearth merged commit 372a11d into AY2021S1-CS2103T-T10-1:master Nov 1, 2020
@pr4aveen pr4aveen added this to the v1.4 milestone Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants