-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add task to project #83
Conversation
…T-T10-1/tp into feature-issue-82
…T-T10-1/tp into feature-issue-82
…T-T10-1/tp into feature-issue-82
…T-T10-1/tp into feature-issue-82
…T-T10-1/tp into feature-issue-82
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
============================================
- Coverage 73.09% 68.20% -4.90%
- Complexity 680 695 +15
============================================
Files 107 114 +7
Lines 2096 2346 +250
Branches 233 265 +32
============================================
+ Hits 1532 1600 +68
- Misses 482 643 +161
- Partials 82 103 +21
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are a lot of formatting problems for javadocs aside from the stuff I pointed out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor coding style errors, otherwise LGTM
src/main/java/seedu/momentum/model/project/UniqueTrackedItemList.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #82
More tests need to be added to test context specific usage.
We might need to redesign how context specific commands work. For example,
AddCommand
can become abstract.AddTaskCommand
andAddProjectCommand
can inheritAddCommand
. A new issue can be raised for this change if there is time