Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task to project #83

Merged
merged 31 commits into from
Oct 24, 2020
Merged

Add task to project #83

merged 31 commits into from
Oct 24, 2020

Conversation

pr4aveen
Copy link
Collaborator

@pr4aveen pr4aveen commented Oct 22, 2020

Closes #82

More tests need to be added to test context specific usage.

We might need to redesign how context specific commands work. For example, AddCommand can become abstract. AddTaskCommand and AddProjectCommand can inherit AddCommand. A new issue can be raised for this change if there is time

@pr4aveen pr4aveen added priority.High Must do type.Epic A big feature which can be broken down into smaller stories e.g. search labels Oct 22, 2020
@pr4aveen pr4aveen added this to the v1.3 milestone Oct 22, 2020
@pr4aveen pr4aveen self-assigned this Oct 22, 2020
@pr4aveen pr4aveen added this to In progress in v1.3 (by 28/10/2020) via automation Oct 22, 2020
@codecov-io
Copy link

codecov-io commented Oct 22, 2020

Codecov Report

Merging #83 into master will decrease coverage by 4.89%.
The diff coverage is 56.89%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #83      +/-   ##
============================================
- Coverage     73.09%   68.20%   -4.90%     
- Complexity      680      695      +15     
============================================
  Files           107      114       +7     
  Lines          2096     2346     +250     
  Branches        233      265      +32     
============================================
+ Hits           1532     1600      +68     
- Misses          482      643     +161     
- Partials         82      103      +21     
Impacted Files Coverage Δ Complexity Δ
...ava/seedu/momentum/logic/commands/HomeCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...du/momentum/logic/commands/ProjectViewCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...omentum/logic/parser/ProjectViewCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...seedu/momentum/logic/parser/SortCommandParser.java 100.00% <ø> (ø) 14.00 <0.00> (ø)
...c/main/java/seedu/momentum/model/project/Task.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...tum/model/project/comparators/DeadlineCompare.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...java/seedu/momentum/model/util/SampleDataUtil.java 33.33% <0.00%> (ø) 2.00 <0.00> (ø)
...n/java/seedu/momentum/storage/JsonAdaptedTask.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/momentum/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/momentum/ui/TimerCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87fe60...bef220e. Read the comment docs.

@pr4aveen pr4aveen marked this pull request as ready for review October 23, 2020 09:02
Copy link
Collaborator

@claracheong4 claracheong4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are a lot of formatting problems for javadocs aside from the stuff I pointed out.

Copy link
Collaborator

@khoodehui khoodehui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor coding style errors, otherwise LGTM

v1.3 (by 28/10/2020) automation moved this from In progress to Reviewer approved Oct 23, 2020
Copy link
Collaborator

@kkangs0226 kkangs0226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pr4aveen pr4aveen merged commit 09a99f0 into master Oct 24, 2020
v1.3 (by 28/10/2020) automation moved this from Reviewer approved to Done Oct 24, 2020
@pr4aveen pr4aveen deleted the feature-issue-82 branch October 24, 2020 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Epic A big feature which can be broken down into smaller stories e.g. search
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

As a user, I should be able to create tasks within a project so that I can better organize my work
6 participants