Branch tab module :( #111
Merged
Branch tab module :( #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
October 22, 2020 13:44
todo in AddCommand, StorageManager
Add getters for UniqueModuleList through Model, Logic interfaces Incorporate basic Ui for displaying modules only. - ModuleListPanel - ModuleCard - ModuleListCard.fxml - ModuleListPanel.fxml - MainWindow
Save file is shared in tr4cker.json because of tr4cker.java being data wrapper for all tr4cker data
- modules must not have existing tasks to be deleted - tasks can only add modules that exist Add visibility for tasks in module tab
…dule # Conflicts: # src/main/java/seedu/tr4cker/logic/Logic.java # src/main/java/seedu/tr4cker/model/Model.java # src/main/java/seedu/tr4cker/ui/MainWindow.java
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
============================================
- Coverage 65.09% 63.69% -1.40%
- Complexity 536 619 +83
============================================
Files 91 103 +12
Lines 1842 2154 +312
Branches 192 249 +57
============================================
+ Hits 1199 1372 +173
- Misses 584 702 +118
- Partials 59 80 +21
Continue to review full report at Codecov.
|
ruilingk
reviewed
Oct 25, 2020
| } | ||
| } | ||
|
|
||
| public void setModules(UniqueModuleList replacement) { |
There was a problem hiding this comment.
Missing JavaDocs for public method.
There was a problem hiding this comment.
Idk why it doesn't show its been updated
This was
linked to
issues
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.