Branch feature countdown #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add exceptions classes to support events list.
Add Event methods in Model, ModelManager, ReadOnlyTr4cker, Tr4cker, ReadOnlyUserPrefs, UserPrefs.
More crucial reason: May need to merge from upstream because I did not do so before starting this branch.
...but it doesnt show the events.
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
============================================
- Coverage 63.57% 61.74% -1.84%
- Complexity 619 660 +41
============================================
Files 103 112 +9
Lines 2158 2363 +205
Branches 249 274 +25
============================================
+ Hits 1372 1459 +87
- Misses 706 802 +96
- Partials 80 102 +22
Continue to review full report at Codecov.
|
cwenling
requested review from
ruilingk and
hanweic53
and removed request for
ruilingk
ruilingk
reviewed
Oct 25, 2020
| @@ -46,6 +47,8 @@ | |||
| /** Returns an unmodifiable view of the filtered list of tasks for PlannerDay. */ | |||
| ObservableList<Task> getPlannerFilteredTaskList(); | |||
|
|
|||
| /** Returns an unmodifiable view of the filtered list of events. */ | |||
| ObservableList<Event> getFilteredEventList(); | |||
There was a problem hiding this comment.
Maybe can add a new line here for readability.
| @@ -88,6 +89,9 @@ public ReadOnlyTr4cker getTr4cker() { | |||
| } | |||
|
|
|||
| @Override | |||
| public ObservableList<Event> getFilteredEventList() { | |||
| return model.getFilteredEventsList(); | |||
| } | |||
There was a problem hiding this comment.
Here too! :')
ModelManager.java too.
| events.remove(key); | ||
| } | ||
|
|
||
| public Event firstEvent() { |
There was a problem hiding this comment.
Missing Javadocs for public methods.
| public ObservableList<Event> getEventList() { | ||
| events.sortEventsByDate(); | ||
| return events.asUnmodifiableObservableList(); | ||
| } |
| public class EventName { | ||
|
|
||
| public static final String MESSAGE_CONSTRAINTS = | ||
| "Names should only contain alphanumeric characters and spaces, and it should not be blank"; |
There was a problem hiding this comment.
Maybe can specify "Event names should only..."?
| } | ||
| } | ||
|
|
||
| public void setEvents(seedu.tr4cker.model.countdown.UniqueEventList replacement) { |
There was a problem hiding this comment.
Missing Javadocs.
And also the parameter in method signature should just be UniqueEventList and then import seedu.tr4cker.model...!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im very sorrry
im still not done.
sorry.