Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch feature countdown event date bug fix #202

Merged

Conversation

cwenling
Copy link

@cwenling cwenling commented Nov 7, 2020

No description provided.

@cwenling cwenling added this to the v1.4 milestone Nov 7, 2020
@codecov-io
Copy link

codecov-io commented Nov 7, 2020

Codecov Report

Merging #202 (d1a9416) into master (6a4e167) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #202      +/-   ##
============================================
+ Coverage     63.59%   63.61%   +0.01%     
- Complexity      816      821       +5     
============================================
  Files           126      126              
  Lines          2923     2930       +7     
  Branches        363      368       +5     
============================================
+ Hits           1859     1864       +5     
+ Misses          942      941       -1     
- Partials        122      125       +3     
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/tr4cker/model/countdown/EventDate.java 91.17% <66.66%> (-5.12%) 20.00 <5.00> (+5.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a4e167...d1a9416. Read the comment docs.

Copy link
Collaborator

@ruilingk ruilingk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cwenling cwenling merged commit 7e572ac into AY2021S1-CS2103T-T10-2:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] Countdown adds a wrong date when a leap year is attempted to be inputted.
3 participants