Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for daily feature #219

Merged
merged 6 commits into from
Nov 9, 2020
Merged

add tests for daily feature #219

merged 6 commits into from
Nov 9, 2020

Conversation

yingqi0607
Copy link

No description provided.

@yingqi0607 yingqi0607 added this to the v1.4 milestone Nov 8, 2020
@cwenling
Copy link

cwenling commented Nov 8, 2020

@codecov-io

please comment

ruilingk
ruilingk reviewed Nov 8, 2020
View reviewed changes
Copy link
Collaborator

@ruilingk ruilingk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor tweaks and it lgtm

src/test/java/seedu/tr4cker/logic/commands/DailyCommandTest.java Outdated Show resolved Hide resolved
src/test/java/seedu/tr4cker/logic/parser/DailyCommandParserTest.java Show resolved Hide resolved
src/test/java/seedu/tr4cker/logic/parser/TodoCommandParserTest.java Show resolved Hide resolved
src/test/java/seedu/tr4cker/model/daily/TodoTest.java Show resolved Hide resolved
ethan-l-m-e
ethan-l-m-e reviewed Nov 8, 2020
View reviewed changes
Copy link

@ethan-l-m-e ethan-l-m-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice naming for test case method names.

ethan-l-m-e
ethan-l-m-e approved these changes Nov 9, 2020
View reviewed changes
Copy link

@ethan-l-m-e ethan-l-m-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yingqi0607 yingqi0607 merged commit 8232714 into AY2021S1-CS2103T-T10-2:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruilingk ruilingk ruilingk left review comments

@ethan-l-m-e ethan-l-m-e ethan-l-m-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yingqi0607 @cwenling @ruilingk @ethan-l-m-e