Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch bugs modules #224

Merged

Conversation

ethan-l-m-e
Copy link

Module tab now refreshes on switching to it.

Modules can be deleted when related tasks are complete.
Tasks that are complete and no longer editable can keep deleted modules.

Testcases.

Modules del error message to follow countdowns

Copy link

@hanweic53 hanweic53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge.

@codecov-io
Copy link

Codecov Report

Merging #224 (d7850c7) into master (7b4d2c6) will increase coverage by 0.82%.
The diff coverage is 60.86%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #224      +/-   ##
============================================
+ Coverage     67.94%   68.76%   +0.82%     
- Complexity      924      946      +22     
============================================
  Files           126      126              
  Lines          3048     3064      +16     
  Branches        402      407       +5     
============================================
+ Hits           2071     2107      +36     
+ Misses          842      825      -17     
+ Partials        135      132       -3     
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/seedu/tr4cker/logic/LogicManager.java 66.66% <0.00%> (+10.78%) 12.00 <0.00> (+5.00)
...seedu/tr4cker/storage/JsonSerializableTr4cker.java 84.61% <0.00%> (ø) 11.00 <0.00> (ø)
src/main/java/seedu/tr4cker/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../main/java/seedu/tr4cker/ui/module/ModuleCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/tr4cker/model/Tr4cker.java 91.35% <75.00%> (+8.02%) 33.00 <0.00> (+4.00)
...va/seedu/tr4cker/logic/commands/ModuleCommand.java 94.59% <100.00%> (+0.15%) 16.00 <0.00> (ø)
...eedu/tr4cker/logic/parser/ModuleCommandParser.java 95.45% <100.00%> (ø) 11.00 <0.00> (ø)
...in/java/seedu/tr4cker/logic/parser/ParserUtil.java 92.00% <100.00%> (+0.51%) 39.00 <4.00> (+4.00)
src/main/java/seedu/tr4cker/model/Model.java 55.55% <100.00%> (+5.55%) 5.00 <0.00> (ø)
...rc/main/java/seedu/tr4cker/model/ModelManager.java 95.53% <100.00%> (+10.57%) 56.00 <1.00> (+6.00)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4d2c6...d7850c7. Read the comment docs.

@ethan-l-m-e ethan-l-m-e merged commit f63664a into AY2021S1-CS2103T-T10-2:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants