Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing Up or Down would navigate through the command history #109

Merged
merged 5 commits into from
Oct 23, 2020
Merged

Conversation

xuey0ng
Copy link

@xuey0ng xuey0ng commented Oct 22, 2020

Closes #74

@codecov-io
Copy link

codecov-io commented Oct 22, 2020

Codecov Report

Merging #109 into master will decrease coverage by 0.28%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #109      +/-   ##
============================================
- Coverage     42.73%   42.45%   -0.29%     
  Complexity      467      467              
============================================
  Files           105      105              
  Lines          2272     2287      +15     
  Branches        233      237       +4     
============================================
  Hits            971      971              
- Misses         1181     1196      +15     
  Partials        120      120              
Impacted Files Coverage Δ Complexity Δ
src/main/java/chopchop/ui/CommandBox.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c31f68c...d4149b9. Read the comment docs.

@xuey0ng xuey0ng marked this pull request as draft October 22, 2020 18:57
@xuey0ng
Copy link
Author

xuey0ng commented Oct 22, 2020

Realised a potential bug due to incorrect pointer amendment, will fix

@xuey0ng xuey0ng marked this pull request as ready for review October 23, 2020 01:18
@xuey0ng
Copy link
Author

xuey0ng commented Oct 23, 2020

Realised a potential bug due to incorrect pointer amendment, will fix

ok d

@Trav1sT Trav1sT merged commit 1d13b18 into master Oct 23, 2020
@xuey0ng xuey0ng added this to the v1.3 milestone Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI should handle escape key
3 participants