Add 'view' command #127
Merged
Add 'view' command #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
============================================
- Coverage 46.54% 46.19% -0.36%
Complexity 703 703
============================================
Files 119 121 +2
Lines 2892 2914 +22
Branches 391 394 +3
============================================
Hits 1346 1346
- Misses 1374 1396 +22
Partials 172 172
Continue to review full report at Codecov.
|
zhiayang
reviewed
Oct 24, 2020
Comment on lines
40
to
42
| .findRecipeWithName(this.item.getName()) | ||
| .orElseThrow(() -> new CommandException(String.format(MESSAGE_RECIPE_NOT_FOUND, | ||
| this.item.getName()))); |
There was a problem hiding this comment.
shouldn't this also check if the item was a number? wouldn't you want to let the user do view #3 for example
Comment on lines
27
to
29
| if (!args.getCommand().equals(commandName)) { | ||
| return Result.error("invalid command '%s' (expected '%s')", args.getCommand(), commandName); | ||
| } |
There was a problem hiding this comment.
I changed all of these to assertions a while ago, this should probably be changed too
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #112