Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edit command #137

Merged
merged 12 commits into from
Oct 25, 2020
Merged

Add edit command #137

merged 12 commits into from
Oct 25, 2020

Conversation

seowalex
Copy link

@seowalex seowalex commented Oct 24, 2020

Fixes #87 and fixes #140. Errors are however still not being propagated correctly, see #139.

@codecov-io
Copy link

codecov-io commented Oct 24, 2020

Codecov Report

Merging #137 into master will decrease coverage by 0.89%.
The diff coverage is 29.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #137      +/-   ##
============================================
- Coverage     47.42%   46.52%   -0.90%     
- Complexity      692      703      +11     
============================================
  Files           119      119              
  Lines          2834     2893      +59     
  Branches        380      392      +12     
============================================
+ Hits           1344     1346       +2     
- Misses         1322     1374      +52     
- Partials        168      173       +5     
Impacted Files Coverage Δ Complexity Δ
...ava/chopchop/logic/commands/EditRecipeCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...in/java/chopchop/logic/edit/TagEditDescriptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...main/java/chopchop/logic/parser/CommandParser.java 84.09% <0.00%> (-1.96%) 19.00 <0.00> (ø)
...pchop/logic/parser/commands/EditCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ain/java/chopchop/model/attributes/ExpiryDate.java 73.68% <0.00%> (ø) 6.00 <0.00> (ø)
src/main/java/chopchop/model/attributes/Step.java 60.00% <0.00%> (-10.00%) 5.00 <3.00> (+1.00) ⬇️
...model/attributes/TagContainsKeywordsPredicate.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../main/java/chopchop/model/util/SampleDataUtil.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/chopchop/ui/DisplayController.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/chopchop/ui/IngredientCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed54721...01148db. Read the comment docs.

@seowalex seowalex marked this pull request as ready for review October 25, 2020 07:23
@seowalex seowalex added this to the v1.3 milestone Oct 25, 2020
@zhiayang
Copy link

👍

@zhiayang zhiayang merged commit 5e53b10 into master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate ingredients can be added to recipes Cannot edit recipes
3 participants