Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation bar indicates which button is in play #150

Merged
merged 4 commits into from
Oct 25, 2020
Merged

Navigation bar indicates which button is in play #150

merged 4 commits into from
Oct 25, 2020

Conversation

xuey0ng
Copy link

@xuey0ng xuey0ng commented Oct 25, 2020

#Closes #72

@xuey0ng xuey0ng added this to the v1.3 milestone Oct 25, 2020
@codecov-io
Copy link

codecov-io commented Oct 25, 2020

Codecov Report

Merging #150 into master will decrease coverage by 0.31%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #150      +/-   ##
============================================
- Coverage     46.10%   45.79%   -0.32%     
  Complexity      703      703              
============================================
  Files           119      119              
  Lines          2915     2935      +20     
  Branches        396      396              
============================================
  Hits           1344     1344              
- Misses         1402     1422      +20     
  Partials        169      169              
Impacted Files Coverage Δ Complexity Δ
src/main/java/chopchop/ui/DisplayController.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 534daa8...0f7baa3. Read the comment docs.

@zhiayang
Copy link

👍

@zhiayang zhiayang merged commit 3190332 into master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation Bar should have some form of indication which tab is selected
3 participants