Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #148 - allows spaces in search terms for filtering by tag and ingredient #157

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

hjl99
Copy link

@hjl99 hjl99 commented Oct 25, 2020

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #157 into master will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #157      +/-   ##
============================================
- Coverage     47.08%   47.03%   -0.05%     
  Complexity      747      747              
============================================
  Files           119      119              
  Lines          3020     3023       +3     
  Branches        417      417              
============================================
  Hits           1422     1422              
- Misses         1435     1438       +3     
  Partials        163      163              
Impacted Files Coverage Δ Complexity Δ
...hop/logic/parser/commands/FilterCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...tributes/IngredientsContainsKeywordsPredicate.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...model/attributes/TagContainsKeywordsPredicate.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef2d298...1e795a3. Read the comment docs.

@hjl99 hjl99 requested a review from zhiayang October 25, 2020 18:47
@zhiayang zhiayang merged commit ea4f7ad into master Oct 26, 2020
@zhiayang
Copy link

👍

@seowalex seowalex added this to the v1.3 milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants