Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the help command useful #181

Merged
merged 11 commits into from
Oct 27, 2020
Merged

Make the help command useful #181

merged 11 commits into from
Oct 27, 2020

Conversation

zhiayang
Copy link

Closes #136, closes #160.

No need to print usage because:

  1. the box is too small
  2. just have a link to the UG

@zhiayang zhiayang added this to the v1.3 milestone Oct 27, 2020
@zhiayang zhiayang marked this pull request as ready for review October 27, 2020 05:54
@codecov-io
Copy link

codecov-io commented Oct 27, 2020

Codecov Report

Merging #181 into master will increase coverage by 1.88%.
The diff coverage is 54.86%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #181      +/-   ##
============================================
+ Coverage     41.91%   43.79%   +1.88%     
- Complexity      762      826      +64     
============================================
  Files           134      135       +1     
  Lines          3519     3715     +196     
  Branches        483      503      +20     
============================================
+ Hits           1475     1627     +152     
- Misses         1872     1915      +43     
- Partials        172      173       +1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/chopchop/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/chopchop/commons/util/Strings.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/main/java/chopchop/logic/commands/Command.java 35.29% <ø> (ø) 3.00 <0.00> (ø)
...ava/chopchop/logic/commands/MakeRecipeCommand.java 12.24% <0.00%> (-0.80%) 2.00 <0.00> (ø)
...main/java/chopchop/logic/commands/QuitCommand.java 33.33% <0.00%> (-33.34%) 2.00 <0.00> (ø)
...main/java/chopchop/logic/commands/RedoCommand.java 25.00% <0.00%> (-15.00%) 2.00 <0.00> (ø)
...hop/logic/commands/StatsIngredientDateCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...hopchop/logic/commands/StatsRecipeDateCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...hop/logic/commands/StatsRecipeMostMadeCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...main/java/chopchop/logic/commands/UndoCommand.java 25.00% <0.00%> (-15.00%) 2.00 <0.00> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a2cdc6...42cc1f6. Read the comment docs.

@seowalex seowalex merged commit 93358fe into master Oct 27, 2020
@zhiayang zhiayang deleted the bugfix/160 branch October 27, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify all the COMMAND_USAGE strings with whatever we have in the User Guide Help command should print usage
3 participants