Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add predicate tests #182

Merged
merged 4 commits into from
Oct 27, 2020
Merged

Add predicate tests #182

merged 4 commits into from
Oct 27, 2020

Conversation

hjl99
Copy link

@hjl99 hjl99 commented Oct 27, 2020

Closes #172

@hjl99 hjl99 added the tests label Oct 27, 2020
@hjl99 hjl99 added this to the v1.3 milestone Oct 27, 2020
@codecov-io
Copy link

Codecov Report

Merging #182 into master will increase coverage by 0.82%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #182      +/-   ##
============================================
+ Coverage     41.91%   42.73%   +0.82%     
- Complexity      762      790      +28     
============================================
  Files           134      134              
  Lines          3519     3519              
  Branches        483      483              
============================================
+ Hits           1475     1504      +29     
+ Misses         1872     1839      -33     
- Partials        172      176       +4     
Impacted Files Coverage Δ Complexity Δ
...ain/java/chopchop/model/attributes/ExpiryDate.java 73.68% <0.00%> (ø) 8.00% <0.00%> (+2.00%)
...attributes/ExpiryDateMatchesKeywordsPredicate.java 77.77% <0.00%> (+77.77%) 7.00% <0.00%> (+7.00%)
...model/attributes/TagContainsKeywordsPredicate.java 84.61% <0.00%> (+84.61%) 9.00% <0.00%> (+9.00%)
...tributes/IngredientsContainsKeywordsPredicate.java 100.00% <0.00%> (+100.00%) 10.00% <0.00%> (+10.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a2cdc6...e841ee8. Read the comment docs.

@zhiayang
Copy link

👍

@zhiayang zhiayang merged commit 5c6ece5 into master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing tests for filter command related predicates
3 participants