Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI #191

Merged
merged 17 commits into from
Oct 29, 2020
Merged

Update UI #191

merged 17 commits into from
Oct 29, 2020

Conversation

seowalex
Copy link

Update UI to use relative positioning so that the application can be fullscreened.

@seowalex seowalex added this to the v1.4 milestone Oct 28, 2020
@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #191 into master will decrease coverage by 0.75%.
The diff coverage is 1.74%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #191      +/-   ##
============================================
- Coverage     55.45%   54.70%   -0.76%     
+ Complexity     1115     1114       -1     
============================================
  Files           138      140       +2     
  Lines          3897     3945      +48     
  Branches        518      517       -1     
============================================
- Hits           2161     2158       -3     
- Misses         1580     1630      +50     
- Partials        156      157       +1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/chopchop/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/chopchop/logic/LogicManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...chop/logic/commands/ListRecommendationCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...pchop/logic/parser/commands/ListCommandParser.java 66.66% <0.00%> (-13.34%) 5.00 <0.00> (ø)
...op/logic/recommendation/RecommendationManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/chopchop/ui/ClickableLink.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/chopchop/ui/CommandBox.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/chopchop/ui/CommandOutput.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/chopchop/ui/DisplayController.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/chopchop/ui/DisplayNavigator.java 0.00% <0.00%> (ø) 1.00 <0.00> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 097009e...cfd41e3. Read the comment docs.

@zhiayang zhiayang merged commit 70081cf into master Oct 29, 2020
@zhiayang
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants