forked from nus-cs2103-AY2021S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup for 1.3 #198
Merged
Merged
Cleanup for 1.3 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
============================================
+ Coverage 54.70% 58.80% +4.10%
- Complexity 1114 1176 +62
============================================
Files 140 140
Lines 3945 3918 -27
Branches 517 513 -4
============================================
+ Hits 2158 2304 +146
+ Misses 1630 1475 -155
+ Partials 157 139 -18
Continue to review full report at Codecov.
|
zhiayang
force-pushed
the
zy/cleanup-2
branch
2 times, most recently
from
October 29, 2020 12:10
c94ccd9
to
b967903
Compare
Since they are created by the DisplayController every time the list changes, the panels themselves don't need to observe the list. This also probably removes a big memory leak.
zhiayang
force-pushed
the
zy/cleanup-2
branch
from
October 29, 2020 13:49
4ee8251
to
86e9f96
Compare
Looks good to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.