Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for 1.3 #198

Merged
merged 11 commits into from
Oct 29, 2020
Merged

Cleanup for 1.3 #198

merged 11 commits into from
Oct 29, 2020

Conversation

zhiayang
Copy link

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #198 into master will increase coverage by 4.10%.
The diff coverage is 87.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #198      +/-   ##
============================================
+ Coverage     54.70%   58.80%   +4.10%     
- Complexity     1114     1176      +62     
============================================
  Files           140      140              
  Lines          3945     3918      -27     
  Branches        517      513       -4     
============================================
+ Hits           2158     2304     +146     
+ Misses         1630     1475     -155     
+ Partials        157      139      -18     
Impacted Files Coverage Δ Complexity Δ
src/main/java/chopchop/commons/util/Result.java 100.00% <ø> (+13.15%) 53.00 <0.00> (+6.00)
.../chopchop/logic/commands/AddIngredientCommand.java 63.04% <ø> (-0.79%) 11.00 <0.00> (-1.00)
...java/chopchop/logic/commands/AddRecipeCommand.java 70.27% <ø> (-0.79%) 12.00 <0.00> (-1.00)
src/main/java/chopchop/logic/commands/Command.java 64.70% <ø> (ø) 5.00 <0.00> (ø)
...opchop/logic/commands/DeleteIngredientCommand.java 51.28% <ø> (-1.22%) 12.00 <0.00> (-1.00)
...a/chopchop/logic/commands/DeleteRecipeCommand.java 84.21% <ø> (-0.79%) 10.00 <0.00> (-1.00)
...ava/chopchop/logic/commands/EditRecipeCommand.java 9.00% <ø> (-0.91%) 4.00 <0.00> (-1.00)
...opchop/logic/commands/FilterIngredientCommand.java 78.26% <ø> (-0.91%) 12.00 <0.00> (-1.00)
...a/chopchop/logic/commands/FilterRecipeCommand.java 86.95% <ø> (-0.55%) 14.00 <0.00> (-1.00)
...chopchop/logic/commands/FindIngredientCommand.java 80.00% <ø> (-1.25%) 9.00 <0.00> (-1.00)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70081cf...9669f5a. Read the comment docs.

@zhiayang zhiayang force-pushed the zy/cleanup-2 branch 2 times, most recently from c94ccd9 to b967903 Compare October 29, 2020 12:10
@xuey0ng
Copy link

xuey0ng commented Oct 29, 2020

Looks good to merge!

@xuey0ng xuey0ng merged commit 4437a70 into master Oct 29, 2020
@zhiayang zhiayang deleted the zy/cleanup-2 branch October 31, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants