Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #204

Merged
merged 12 commits into from
Oct 31, 2020
Merged

Cleanup #204

merged 12 commits into from
Oct 31, 2020

Conversation

seowalex
Copy link

@seowalex seowalex commented Oct 30, 2020

Just some small fixes that didn't make it into 1.3.

Fixes #199, fixes #200, fixes #203 and fixes #234.

@seowalex seowalex added this to the v1.4 milestone Oct 30, 2020
@seowalex seowalex changed the title Fix raw link in output Cleanup Oct 30, 2020
@codecov-io
Copy link

codecov-io commented Oct 30, 2020

Codecov Report

Merging #204 into master will decrease coverage by 0.04%.
The diff coverage is 7.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #204      +/-   ##
============================================
- Coverage     77.60%   77.56%   -0.05%     
  Complexity     1523     1523              
============================================
  Files           141      141              
  Lines          3979     3984       +5     
  Branches        529      532       +3     
============================================
+ Hits           3088     3090       +2     
- Misses          813      816       +3     
  Partials         78       78              
Impacted Files Coverage Δ Complexity Δ
src/main/java/chopchop/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/chopchop/logic/LogicManager.java 66.66% <ø> (ø) 7.00 <0.00> (ø)
src/main/java/chopchop/ui/DisplayController.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/chopchop/ui/DisplayNavigator.java 0.00% <0.00%> (ø) 1.00 <0.00> (ø)
src/main/java/chopchop/ui/IngredientViewPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/chopchop/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/chopchop/ui/RecipeViewPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/chopchop/ui/RecommendationCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...main/java/chopchop/ui/RecommendationViewPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...main/java/chopchop/logic/commands/HelpCommand.java 89.02% <100.00%> (+0.27%) 18.00 <0.00> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e9d786...061b79f. Read the comment docs.

@zhiayang
Copy link

@seowalex can you make the "see the User Guide for a list of commands" part link to the command summary instead? teh href is CommandSummary.

@seowalex seowalex marked this pull request as ready for review October 31, 2020 10:49
@zhiayang zhiayang merged commit 4b874cf into master Oct 31, 2020
@zhiayang
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants