Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undo/redo #41

Merged
merged 8 commits into from
Oct 12, 2020
Merged

Add undo/redo #41

merged 8 commits into from
Oct 12, 2020

Conversation

seowalex
Copy link

@seowalex seowalex commented Oct 7, 2020

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #41 into master will decrease coverage by 2.23%.
The diff coverage is 24.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #41      +/-   ##
============================================
- Coverage     60.78%   58.54%   -2.24%     
- Complexity      400      404       +4     
============================================
  Files            78       83       +5     
  Lines          1461     1544      +83     
  Branches        137      148      +11     
============================================
+ Hits            888      904      +16     
- Misses          541      606      +65     
- Partials         32       34       +2     
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/AddCommand.java 66.66% <0.00%> (-33.34%) 8.00 <0.00> (ø)
...ain/java/seedu/address/logic/commands/Command.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...java/seedu/address/logic/commands/ExitCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...java/seedu/address/logic/commands/FindCommand.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...java/seedu/address/logic/commands/HelpCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...a/seedu/address/logic/commands/HistoryCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...java/seedu/address/logic/commands/ListCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...java/seedu/address/logic/commands/RedoCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...java/seedu/address/logic/commands/UndoCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../seedu/address/logic/parser/AddressBookParser.java 80.00% <0.00%> (-20.00%) 12.00 <0.00> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c283ac2...2a97567. Read the comment docs.

Copy link

@zhiayang zhiayang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably mostly fine, just reviewing cos i have to

@zhiayang zhiayang added this to the v1.2 milestone Oct 11, 2020
@seowalex seowalex marked this pull request as ready for review October 12, 2020 07:17
@zhiayang zhiayang merged commit ca4413f into AY2021S1-CS2103T-T10-3:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants