Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new commands and integrate undo/redo functionality #96

Merged
merged 24 commits into from
Oct 22, 2020

Conversation

seowalex
Copy link

@seowalex seowalex commented Oct 21, 2020

Adds new commands for making recipes and deleting specific quantities of ingredients. Also integrated undo/redo functionality into all commands that modify the model.

Closes #45, closes #68, closes #88 and closes #92.

@seowalex seowalex added this to the v1.3 milestone Oct 21, 2020
@codecov-io
Copy link

codecov-io commented Oct 21, 2020

Codecov Report

Merging #96 into master will decrease coverage by 1.69%.
The diff coverage is 11.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #96      +/-   ##
============================================
- Coverage     32.33%   30.64%   -1.70%     
- Complexity      517      519       +2     
============================================
  Files           170      177       +7     
  Lines          3321     3511     +190     
  Branches        335      360      +25     
============================================
+ Hits           1074     1076       +2     
- Misses         2128     2314     +186     
- Partials        119      121       +2     
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/chopchop/logic/CommandDispatcher.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...java/chopchop/logic/commands/AddRecipeCommand.java 37.50% <0.00%> (-8.66%) 3.00 <0.00> (ø)
src/main/java/chopchop/logic/commands/Command.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...a/chopchop/logic/commands/DeleteRecipeCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...chopchop/logic/commands/FindIngredientCommand.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...ava/chopchop/logic/commands/FindRecipeCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...main/java/chopchop/logic/commands/HelpCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...chopchop/logic/commands/ListIngredientCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...ava/chopchop/logic/commands/ListRecipeCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ava/chopchop/logic/commands/MakeRecipeCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f2014b...6aec36c. Read the comment docs.

Copy link

@zhiayang zhiayang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

also why tf you got something against using var?

@seowalex
Copy link
Author

Still missing tests, but functionality should all be there.

@seowalex seowalex changed the title Add making recipe and deleting specific quantites of ingredients. Add new commands and integrate undo/redo functionality Oct 22, 2020
@seowalex seowalex marked this pull request as ready for review October 22, 2020 03:04
@zhiayang
Copy link

btw doing closes A, B, C, and D only marks A as being closed by this pr

@seowalex
Copy link
Author

TIL ok will change.

@zhiayang zhiayang merged commit 7a7ad0c into master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants