Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommandBox moved to main display region #99

Merged
merged 44 commits into from
Oct 22, 2020
Merged

CommandBox moved to main display region #99

merged 44 commits into from
Oct 22, 2020

Conversation

xuey0ng
Copy link

@xuey0ng xuey0ng commented Oct 21, 2020

Closes #93 Closes #63

zhiayang and others added 30 commits October 17, 2020 22:10
Add command usage to the error message when applicable (and able)
Make the list commands switch the gui pane
@codecov-io
Copy link

codecov-io commented Oct 22, 2020

Codecov Report

Merging #99 into master will increase coverage by 13.98%.
The diff coverage is 29.34%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #99       +/-   ##
=============================================
+ Coverage     32.33%   46.32%   +13.98%     
+ Complexity      517      464       -53     
=============================================
  Files           170       99       -71     
  Lines          3321     2081     -1240     
  Branches        335      209      -126     
=============================================
- Hits           1074      964      -110     
+ Misses         2128     1000     -1128     
+ Partials        119      117        -2     
Impacted Files Coverage Δ Complexity Δ
src/main/java/chopchop/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...chopchop/logic/commands/ListIngredientCommand.java 66.66% <0.00%> (-33.34%) 2.00 <0.00> (ø)
...ava/chopchop/logic/commands/ListRecipeCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...main/java/chopchop/logic/commands/QuitCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...main/java/chopchop/logic/parser/CommandParser.java 61.53% <0.00%> (-1.62%) 7.00 <0.00> (ø)
...hop/logic/parser/commands/DeleteCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...pchop/logic/parser/commands/FindCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/chopchop/model/attributes/Tag.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../main/java/chopchop/model/util/SampleDataUtil.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/chopchop/ui/CommandBox.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f2014b...7433e15. Read the comment docs.

@Trav1sT Trav1sT merged commit 61f2adc into master Oct 22, 2020
@xuey0ng xuey0ng added this to the v1.3 milestone Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command Box should be larger due to long commands GUI does not scale well to different window sizes
5 participants