Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ui design #108

Merged
merged 1 commit into from
Oct 11, 2020
Merged

Change ui design #108

merged 1 commit into from
Oct 11, 2020

Conversation

samlsm
Copy link

@samlsm samlsm commented Oct 11, 2020

Current design:
Screenshot 2020-10-11 at 12 28 04 PM

@codecov-io
Copy link

Codecov Report

Merging #108 into master will increase coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #108      +/-   ##
============================================
+ Coverage     76.94%   77.39%   +0.44%     
- Complexity      590      603      +13     
============================================
  Files            97       98       +1     
  Lines          1731     1761      +30     
  Branches        178      182       +4     
============================================
+ Hits           1332     1363      +31     
+ Misses          359      357       -2     
- Partials         40       41       +1     
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/model/student/Student.java 97.91% <0.00%> (-2.09%) 23.00% <0.00%> (+2.00%) ⬇️
src/main/java/seedu/address/ui/UiPart.java 84.00% <0.00%> (ø) 4.00% <0.00%> (ø%)
src/main/java/seedu/address/model/UserPrefs.java 80.00% <0.00%> (ø) 10.00% <0.00%> (ø%)
src/main/java/seedu/address/ui/ResultDisplay.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...c/main/java/seedu/address/model/student/Email.java 90.00% <0.00%> (ø) 7.00% <0.00%> (ø%)
.../main/java/seedu/address/commons/util/AppUtil.java 88.88% <0.00%> (ø) 5.00% <0.00%> (ø%)
...ain/java/seedu/address/model/student/Telegram.java 90.00% <0.00%> (ø) 7.00% <0.00%> (ø%)
...in/java/seedu/address/commons/util/StringUtil.java 94.73% <0.00%> (ø) 7.00% <0.00%> (ø%)
...in/java/seedu/address/logic/parser/ParserUtil.java 96.77% <0.00%> (ø) 12.00% <0.00%> (ø%)
...n/java/seedu/address/model/components/tag/Tag.java 80.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1140a0a...54c5d74. Read the comment docs.

Copy link

@ruixuantan ruixuantan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ypinhsuan ypinhsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samlsm samlsm merged commit fb245f7 into AY2021S1-CS2103T-T10-4:master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants