-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model attendance #118
Model attendance #118
Conversation
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
============================================
+ Coverage 77.59% 78.18% +0.58%
- Complexity 693 745 +52
============================================
Files 113 120 +7
Lines 1973 2063 +90
Branches 206 214 +8
============================================
+ Hits 1531 1613 +82
- Misses 397 404 +7
- Partials 45 46 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Though, I think it would be best to further decouple the logic
and model
parts of the house for attendances.
src/main/java/seedu/address/model/attendance/AttendanceRecord.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/model/attendance/AttendanceRecordList.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/model/attendance/AttendanceRecordListTest.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/model/attendance/AttendanceRecordTest.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/model/attendance/AttendanceRecord.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some thoughts and suggestions to improve the defensiveness of the code.
src/main/java/seedu/address/model/attendance/AttendanceRecordList.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/testutil/AttendanceRecordBuilder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! LGTM, just some minor suggestions.
src/main/java/seedu/address/model/attendance/AttendanceRecord.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/model/attendance/AttendanceRecord.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/model/attendance/AttendanceRecordList.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/model/attendance/AttendanceRecordList.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/model/attendance/AttendanceRecordList.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/model/attendance/AttendanceRecordList.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/logic/commands/CommandTestUtil.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/model/attendance/AttendanceTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Dexter Tan <dev@dextertanyj.com>
Resolves #117