Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model attendance #118

Merged
merged 14 commits into from
Oct 15, 2020
Merged

Conversation

ruixuantan
Copy link

Resolves #117

@ruixuantan ruixuantan added this to the v1.3-core milestone Oct 14, 2020
@codecov-io
Copy link

codecov-io commented Oct 14, 2020

Codecov Report

Merging #118 into master will increase coverage by 0.58%.
The diff coverage is 85.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #118      +/-   ##
============================================
+ Coverage     77.59%   78.18%   +0.58%     
- Complexity      693      745      +52     
============================================
  Files           113      120       +7     
  Lines          1973     2063      +90     
  Branches        206      214       +8     
============================================
+ Hits           1531     1613      +82     
- Misses          397      404       +7     
- Partials         45       46       +1     
Impacted Files Coverage Δ Complexity Δ
...dance/exceptions/DuplicateAttendanceException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...eedu/address/model/lesson/NumberOfOccurrences.java 81.81% <0.00%> (+1.81%) 10.00 <0.00> (+1.00)
...main/java/seedu/address/model/attendance/Week.java 71.42% <71.42%> (ø) 9.00 <9.00> (?)
...ava/seedu/address/model/attendance/Attendance.java 81.81% <81.81%> (ø) 10.00 <10.00> (?)
...edu/address/model/attendance/AttendanceRecord.java 93.33% <93.33%> (ø) 9.00 <9.00> (?)
...address/model/attendance/AttendanceRecordList.java 95.23% <95.23%> (ø) 13.00 <13.00> (?)
...ava/seedu/address/commons/util/CollectionUtil.java 94.44% <100.00%> (+6.94%) 9.00 <4.00> (+4.00)
...ndance/exceptions/AttendanceNotFoundException.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...el/attendance/exceptions/InvalidWeekException.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...a/seedu/address/model/moduleclass/ModuleClass.java 100.00% <0.00%> (ø) 17.00% <0.00%> (+2.00%)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f93175...5899e42. Read the comment docs.

Copy link

@dextertanyj dextertanyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Though, I think it would be best to further decouple the logic and model parts of the house for attendances.

Copy link

@ypinhsuan ypinhsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link

@dextertanyj dextertanyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some thoughts and suggestions to improve the defensiveness of the code.

Copy link

@dextertanyj dextertanyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM, just some minor suggestions.

@ruixuantan ruixuantan merged commit f289cd0 into AY2021S1-CS2103T-T10-4:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Attendance Model
5 participants