Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement command and parser support for add lesson #129

Merged

Conversation

junlong4321
Copy link

Resolves #128

@junlong4321 junlong4321 added this to the v1.3-core milestone Oct 15, 2020
@junlong4321 junlong4321 requested review from dextertanyj, a team and ypinhsuan and removed request for a team October 15, 2020 14:22
@codecov-io
Copy link

codecov-io commented Oct 15, 2020

Codecov Report

Merging #129 into master will increase coverage by 0.51%.
The diff coverage is 92.04%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #129      +/-   ##
============================================
+ Coverage     79.04%   79.56%   +0.51%     
- Complexity      764      786      +22     
============================================
  Files           122      124       +2     
  Lines          2114     2202      +88     
  Branches        222      232      +10     
============================================
+ Hits           1671     1752      +81     
- Misses          392      393       +1     
- Partials         51       57       +6     
Impacted Files Coverage Δ Complexity Δ
...seedu/address/logic/commands/AddLessonCommand.java 86.20% <86.20%> (ø) 10.00 <10.00> (?)
...in/java/seedu/address/logic/parser/ParserUtil.java 94.91% <92.85%> (-1.86%) 17.00 <5.00> (+5.00) ⬇️
...u/address/logic/parser/AddLessonCommandParser.java 95.83% <95.83%> (ø) 5.00 <5.00> (?)
...ain/java/seedu/address/logic/parser/CliSyntax.java 92.30% <100.00%> (+4.80%) 1.00 <0.00> (ø)
...va/seedu/address/logic/parser/TutorsPetParser.java 100.00% <100.00%> (ø) 27.00 <0.00> (+1.00)
...a/seedu/address/model/moduleclass/ModuleClass.java 100.00% <100.00%> (ø) 18.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c4f498...3b24996. Read the comment docs.

Copy link

@ypinhsuan ypinhsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But I think you might need to update the TutorsPetParser class with AddLessonCommand

Copy link

@dextertanyj dextertanyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Just needs to add the AddLessonCommand to TutorsPetParser and everything should be good to go.

src/main/java/seedu/address/logic/parser/CliSyntax.java Outdated Show resolved Hide resolved
…into add-lesson-command

# Conflicts:
#	src/main/java/seedu/address/logic/parser/CliSyntax.java

Resolved by adding PREFIX_LESSON_INDEX into CliSyntax.java
Copy link

@ypinhsuan ypinhsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/test/java/seedu/address/testutil/LessonUtil.java Outdated Show resolved Hide resolved
Copy link

@dextertanyj dextertanyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor suggestion for clarity.

src/test/java/seedu/address/testutil/LessonUtil.java Outdated Show resolved Hide resolved
@junlong4321 junlong4321 merged commit b07e950 into AY2021S1-CS2103T-T10-4:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement command and parser support for add lesson
4 participants