-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement command and parser support for add lesson #129
Implement command and parser support for add lesson #129
Conversation
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
============================================
+ Coverage 79.04% 79.56% +0.51%
- Complexity 764 786 +22
============================================
Files 122 124 +2
Lines 2114 2202 +88
Branches 222 232 +10
============================================
+ Hits 1671 1752 +81
- Misses 392 393 +1
- Partials 51 57 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! But I think you might need to update the TutorsPetParser
class with AddLessonCommand
src/main/java/seedu/address/logic/commands/AddLessonCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/commands/AddLessonCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/commands/AddLessonCommand.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Just needs to add the AddLessonCommand
to TutorsPetParser
and everything should be good to go.
…into add-lesson-command # Conflicts: # src/main/java/seedu/address/logic/parser/CliSyntax.java Resolved by adding PREFIX_LESSON_INDEX into CliSyntax.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a minor suggestion for clarity.
Resolves #128