Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attendance command #142

Merged
merged 7 commits into from
Oct 17, 2020

Conversation

samlsm
Copy link

@samlsm samlsm commented Oct 16, 2020

Closes #140

@samlsm samlsm added this to the v1.3-core milestone Oct 16, 2020
@codecov-io
Copy link

codecov-io commented Oct 16, 2020

Codecov Report

Merging #142 into master will decrease coverage by 0.40%.
The diff coverage is 86.08%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #142      +/-   ##
============================================
- Coverage     79.53%   79.13%   -0.41%     
- Complexity      826      853      +27     
============================================
  Files           127      129       +2     
  Lines          2331     2468     +137     
  Branches        244      267      +23     
============================================
+ Hits           1854     1953      +99     
- Misses          418      443      +25     
- Partials         59       72      +13     
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...u/address/logic/parser/AddLessonCommandParser.java 95.65% <ø> (-0.19%) 4.00 <0.00> (-1.00)
...ress/logic/parser/AddModuleClassCommandParser.java 88.88% <ø> (-1.12%) 3.00 <0.00> (-1.00)
.../address/logic/parser/AddStudentCommandParser.java 100.00% <ø> (ø) 4.00 <0.00> (-1.00)
...u/address/logic/commands/AddAttendanceCommand.java 80.59% <80.59%> (ø) 15.00 <15.00> (?)
...in/java/seedu/address/logic/parser/ParserUtil.java 93.58% <89.47%> (-1.33%) 22.00 <5.00> (+5.00) ⬇️
...dress/logic/parser/AddAttendanceCommandParser.java 94.73% <94.73%> (ø) 3.00 <3.00> (?)
...ain/java/seedu/address/logic/parser/CliSyntax.java 93.33% <100.00%> (+1.02%) 1.00 <0.00> (ø)
...va/seedu/address/logic/parser/TutorsPetParser.java 100.00% <100.00%> (ø) 28.00 <0.00> (+1.00)
...edu/address/model/attendance/AttendanceRecord.java 100.00% <100.00%> (ø) 11.00 <1.00> (+1.00)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3f031...48a7e9a. Read the comment docs.

Copy link

@junlong4321 junlong4321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

Copy link

@dextertanyj dextertanyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just needs to include the check for a student not in the class.

Copy link

@dextertanyj dextertanyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor suggestion.

@samlsm samlsm merged commit a466972 into AY2021S1-CS2103T-T10-4:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement command and parser support for add attendenceRecord
4 participants