-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attendance command #142
Add attendance command #142
Conversation
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
============================================
- Coverage 79.53% 79.13% -0.41%
- Complexity 826 853 +27
============================================
Files 127 129 +2
Lines 2331 2468 +137
Branches 244 267 +23
============================================
+ Hits 1854 1953 +99
- Misses 418 443 +25
- Partials 59 72 +13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
src/main/java/seedu/address/logic/commands/AddAttendanceCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/commands/AddAttendanceCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/commands/AddAttendanceCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/commands/AddAttendanceCommand.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just needs to include the check for a student not in the class.
src/main/java/seedu/address/logic/parser/AddAttendanceCommandParser.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/model/attendance/AttendanceRecordListTest.java
Show resolved
Hide resolved
src/test/java/seedu/address/logic/parser/TutorsPetParserTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a minor suggestion.
Closes #140