Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit lesson command #143

Merged

Conversation

ruixuantan
Copy link

Resolves #120

@ruixuantan ruixuantan added this to the v1.3-core milestone Oct 17, 2020
@codecov-io
Copy link

codecov-io commented Oct 17, 2020

Codecov Report

Merging #143 into master will increase coverage by 0.41%.
The diff coverage is 90.98%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #143      +/-   ##
============================================
+ Coverage     80.16%   80.57%   +0.41%     
- Complexity      894      920      +26     
============================================
  Files           134      136       +2     
  Lines          2581     2693     +112     
  Branches        282      309      +27     
============================================
+ Hits           2069     2170     +101     
- Misses          439      440       +1     
- Partials         73       83      +10     
Impacted Files Coverage Δ Complexity Δ
...du/address/logic/commands/DeleteLessonCommand.java 77.77% <33.33%> (-4.58%) 11.00 <0.00> (ø)
...eedu/address/logic/commands/EditLessonCommand.java 91.76% <91.76%> (ø) 17.00 <17.00> (?)
.../address/logic/parser/EditLessonCommandParser.java 92.30% <92.30%> (ø) 8.00 <8.00> (?)
...ava/seedu/address/commons/util/CollectionUtil.java 94.44% <100.00%> (ø) 9.00 <0.00> (ø)
...address/logic/commands/EditModuleClassCommand.java 95.65% <100.00%> (-0.10%) 12.00 <1.00> (ø)
...edu/address/logic/commands/EditStudentCommand.java 96.82% <100.00%> (-0.05%) 12.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 93.58% <100.00%> (ø) 22.00 <0.00> (ø)
...va/seedu/address/logic/parser/TutorsPetParser.java 100.00% <100.00%> (ø) 29.00 <0.00> (+1.00)
src/main/java/seedu/address/model/lesson/Day.java 100.00% <100.00%> (ø) 4.00 <3.00> (ø)
...a/seedu/address/model/moduleclass/ModuleClass.java 100.00% <100.00%> (ø) 18.00 <1.00> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b2be3...f66ee60. Read the comment docs.

Copy link

@junlong4321 junlong4321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, consider adding the assertion to AddLessonCommand and DeleteLessonCommand as well

Copy link

@ypinhsuan ypinhsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM

@ruixuantan ruixuantan merged commit ee93a4f into AY2021S1-CS2103T-T10-4:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement edit lesson command
5 participants