-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit lesson command #143
Edit lesson command #143
Conversation
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
============================================
+ Coverage 80.16% 80.57% +0.41%
- Complexity 894 920 +26
============================================
Files 134 136 +2
Lines 2581 2693 +112
Branches 282 309 +27
============================================
+ Hits 2069 2170 +101
- Misses 439 440 +1
- Partials 73 83 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, consider adding the assertion to AddLessonCommand and DeleteLessonCommand as well
src/main/java/seedu/address/logic/commands/DeleteLessonCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/commands/EditLessonCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/commands/EditLessonCommand.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! LGTM
7a21952
to
f66ee60
Compare
Resolves #120