Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change token delimiter #167

Merged
merged 5 commits into from
Oct 20, 2020
Merged

Change token delimiter #167

merged 5 commits into from
Oct 20, 2020

Conversation

junlong4321
Copy link

Resolves #132

@junlong4321 junlong4321 added this to the v1.3 milestone Oct 20, 2020
@junlong4321 junlong4321 requested review from a team, ruixuantan and samlsm and removed request for a team October 20, 2020 02:19
@codecov-io
Copy link

codecov-io commented Oct 20, 2020 •
edited

Codecov Report

Merging #167 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #167   +/-   ##
=========================================
  Coverage     82.07%   82.07%           
  Complexity      994      994           
=========================================
  Files           146      146           
  Lines          2957     2957           
  Branches        349      349           
=========================================
  Hits           2427     2427           
  Misses          443      443           
  Partials         87       87
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/tutorspet/logic/parser/CliSyntax.java 93.33% <100.00%> (ø) 1.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 237aea5...613f478. Read the comment docs.

ruixuantan
ruixuantan approved these changes Oct 20, 2020
View reviewed changes
Copy link

@ruixuantan ruixuantan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor suggestions.

src/test/java/tutorspet/logic/parser/DeleteAttendanceCommandParserTest.java Outdated Show resolved Hide resolved
src/test/java/tutorspet/logic/parser/DeleteAttendanceCommandParserTest.java Outdated Show resolved Hide resolved
src/test/java/tutorspet/logic/parser/EditLessonCommandParserTest.java Outdated Show resolved Hide resolved
@junlong4321
Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T10-4/tp …
7f7641d 
…into change-token-delimiter

# Conflicts:
#	src/test/java/tutorspet/logic/parser/AddAttendanceCommandParserTest.java
#	src/test/java/tutorspet/logic/parser/DeleteLessonCommandParserTest.java
#	src/test/java/tutorspet/logic/parser/EditLessonCommandParserTest.java
#	src/test/java/tutorspet/logic/parser/FindAttendanceCommandParserTest.java
#	src/test/java/tutorspet/logic/parser/LinkCommandParserTest.java
#	src/test/java/tutorspet/logic/parser/ListStudentCommandParserTest.java
#	src/test/java/tutorspet/logic/parser/UnlinkCommandParserTest.java

Resolved merge conflicts
@junlong4321
Update PR after reviewers' comments
8983645
@junlong4321
Add indentation
613f478
@junlong4321 junlong4321 merged commit 86e0e47 into AY2021S1-CS2103T-T10-4:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruixuantan ruixuantan ruixuantan approved these changes

@samlsm samlsm samlsm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Change token delimiter
4 participants
@junlong4321 @codecov-io @ruixuantan @samlsm