Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lesson UI #194

Merged
merged 3 commits into from
Oct 23, 2020
Merged

Update lesson UI #194

merged 3 commits into from
Oct 23, 2020

Conversation

ypinhsuan
Copy link

@ypinhsuan ypinhsuan commented Oct 23, 2020

image

@ypinhsuan ypinhsuan added this to the v1.3 milestone Oct 23, 2020
@ypinhsuan ypinhsuan requested review from a team, dextertanyj and samlsm and removed request for a team October 23, 2020 12:25
@codecov-io
Copy link

Codecov Report

Merging #194 into master will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #194      +/-   ##
============================================
- Coverage     82.71%   82.59%   -0.13%     
- Complexity     1049     1061      +12     
============================================
  Files           150      151       +1     
  Lines          3107     3160      +53     
  Branches        376      379       +3     
============================================
+ Hits           2570     2610      +40     
- Misses          444      457      +13     
  Partials         93       93              
Impacted Files Coverage Δ Complexity Δ
src/main/java/tutorspet/ui/LessonCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/tutorspet/ui/ModuleClassCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...tutorspet/logic/util/AttendanceRecordListUtil.java 96.34% <0.00%> (-2.10%) 26.00% <0.00%> (+6.00%) ⬇️
...n/java/tutorspet/logic/commands/UnlinkCommand.java 90.62% <0.00%> (-1.05%) 12.00% <0.00%> (ø%)
...rspet/model/moduleclass/UniqueModuleClassList.java 98.00% <0.00%> (-0.15%) 27.00% <0.00%> (ø%)
...n/java/tutorspet/logic/parser/TutorsPetParser.java 100.00% <0.00%> (ø) 34.00% <0.00%> (ø%)
...torspet/logic/parser/EditStudentCommandParser.java
...a/tutorspet/logic/commands/ListStudentCommand.java
...et/logic/parser/DeleteAttendanceCommandParser.java
.../tutorspet/logic/commands/ClearStudentCommand.java
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 060334c...8e98a40. Read the comment docs.

Copy link

@samlsm samlsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Might be a good idea to add a picture of the updated UI in the description section?

src/main/java/tutorspet/ui/LessonCard.java Outdated Show resolved Hide resolved
Copy link

@dextertanyj dextertanyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job and works well! LGTM!

src/main/java/tutorspet/ui/LessonCard.java Outdated Show resolved Hide resolved
@ypinhsuan ypinhsuan merged commit ad00e41 into AY2021S1-CS2103T-T10-4:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants