Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove address field #20

Merged

Conversation

ruixuantan
Copy link

No description provided.

Copy link

@junlong4321 junlong4321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue with comma. Other than that, LGTM.

Copy link

@dextertanyj dextertanyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the suggestions, LGTM.

@dextertanyj dextertanyj added this to the v1.2 milestone Sep 21, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #20 into working-v1.2 will decrease coverage by 0.63%.
The diff coverage is 90.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             working-v1.2      #20      +/-   ##
==================================================
- Coverage           72.31%   71.68%   -0.64%     
+ Complexity            400      387      -13     
==================================================
  Files                  70       69       -1     
  Lines                1228     1190      -38     
  Branches              124      117       -7     
==================================================
- Hits                  888      853      -35     
+ Misses                308      306       -2     
+ Partials               32       31       -1     
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...ain/java/seedu/address/logic/parser/CliSyntax.java 80.00% <ø> (-3.34%) 1.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 96.77% <ø> (-0.45%) 12.00 <0.00> (-2.00)
.../java/seedu/address/model/util/SampleDataUtil.java 20.00% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/seedu/address/ui/PersonCard.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...c/main/java/seedu/address/model/person/Person.java 97.22% <66.66%> (-0.34%) 19.00 <0.00> (-2.00)
...java/seedu/address/logic/commands/EditCommand.java 96.72% <100.00%> (-0.30%) 12.00 <0.00> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 91.66% <100.00%> (-0.65%) 10.00 <0.00> (-1.00)
.../java/seedu/address/storage/JsonAdaptedPerson.java 100.00% <100.00%> (ø) 9.00 <0.00> (-2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd2f16...2cd1298. Read the comment docs.

@ruixuantan ruixuantan changed the base branch from working-v1.2 to master September 23, 2020 01:03
@dextertanyj
Copy link

Can you rebase and then should be good to go.

@ruixuantan ruixuantan merged commit a04f149 into AY2021S1-CS2103T-T10-4:master Sep 23, 2020
@dextertanyj dextertanyj linked an issue Sep 23, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove address field for Person
4 participants