-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove address field #20
Remove address field #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor issue with comma. Other than that, LGTM.
src/test/java/seedu/address/logic/parser/AddCommandParserTest.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/logic/parser/AddCommandParserTest.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/logic/parser/AddCommandParserTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the suggestions, LGTM.
src/test/java/seedu/address/logic/parser/AddCommandParserTest.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/logic/parser/AddCommandParserTest.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/logic/parser/AddCommandParserTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## working-v1.2 #20 +/- ##
==================================================
- Coverage 72.31% 71.68% -0.64%
+ Complexity 400 387 -13
==================================================
Files 70 69 -1
Lines 1228 1190 -38
Branches 124 117 -7
==================================================
- Hits 888 853 -35
+ Misses 308 306 -2
+ Partials 32 31 -1
Continue to review full report at Codecov.
|
62666f1
to
ee90873
Compare
Can you rebase and then should be good to go. |
ee90873
to
1a19bdb
Compare
No description provided.