Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate error messages #206

Conversation

dextertanyj
Copy link

Resolves #149

@dextertanyj dextertanyj added this to the v1.3-patch milestone Oct 26, 2020
@dextertanyj dextertanyj requested review from a team, ruixuantan and samlsm and removed request for a team October 26, 2020 07:22
@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #206 into master will increase coverage by 0.03%.
The diff coverage is 94.54%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #206      +/-   ##
============================================
+ Coverage     82.67%   82.70%   +0.03%     
  Complexity     1065     1065              
============================================
  Files           148      148              
  Lines          3168     3174       +6     
  Branches        381      381              
============================================
+ Hits           2619     2625       +6     
  Misses          455      455              
  Partials         94       94              
Impacted Files Coverage Δ Complexity Δ
src/main/java/tutorspet/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ain/java/tutorspet/logic/commands/ExitCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...ain/java/tutorspet/logic/commands/RedoCommand.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...in/java/tutorspet/logic/commands/ResetCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...ain/java/tutorspet/logic/commands/UndoCommand.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...ic/commands/moduleclass/AddModuleClassCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
.../commands/moduleclass/ClearModuleClassCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...spet/logic/commands/student/AddStudentCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...et/logic/commands/student/ClearStudentCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...c/main/java/tutorspet/logic/parser/ParserUtil.java 93.58% <ø> (ø) 22.00 <0.00> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 900344b...11de770. Read the comment docs.

Copy link

@ruixuantan ruixuantan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@samlsm samlsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dextertanyj dextertanyj merged commit 1aa4f94 into AY2021S1-CS2103T-T10-4:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize error messages displayed to users
4 participants