Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pe bug fixes #253

Merged
merged 6 commits into from
Nov 3, 2020
Merged

Conversation

ruixuantan
Copy link

After starting Tutor's Pet:
Screenshot 2020-11-02 at 9 53 51 AM

Should I refactor the createTag method to make it more testable and actually test it?

Resolves #235
Resolves #246

@ruixuantan ruixuantan added this to the v1.4 milestone Nov 2, 2020
@codecov-io
Copy link

Codecov Report

Merging #253 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #253   +/-   ##
=========================================
  Coverage     83.23%   83.23%           
  Complexity     1080     1080           
=========================================
  Files           148      148           
  Lines          3179     3179           
  Branches        381      381           
=========================================
  Hits           2646     2646           
  Misses          442      442           
  Partials         91       91           
Impacted Files Coverage Δ Complexity Δ
src/main/java/tutorspet/ui/LessonCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/tutorspet/ui/StudentCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af3e6f9...d7bc481. Read the comment docs.

Copy link

@ypinhsuan ypinhsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@dextertanyj dextertanyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Interesting cause of the tag colour bug. I think it would be good to refactor the tag logic into its own class, that way the tag colour does not depend on the student card class either.

docs/UserGuide.md Outdated Show resolved Hide resolved
Copy link

@ypinhsuan ypinhsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link

@dextertanyj dextertanyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

@ruixuantan ruixuantan merged commit 8d99808 into AY2021S1-CS2103T-T10-4:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants