Rename AddressBook and Person #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uan/tp into ypinhsuan-rename-addressbook-person # Conflicts: # src/main/java/seedu/address/logic/commands/AddCommand.java # src/main/java/seedu/address/logic/commands/EditCommand.java # src/main/java/seedu/address/logic/parser/AddCommandParser.java # src/main/java/seedu/address/logic/parser/EditCommandParser.java # src/main/java/seedu/address/logic/parser/ParserUtil.java # src/main/java/seedu/address/model/student/Address.java # src/main/java/seedu/address/model/student/Student.java # src/main/java/seedu/address/model/util/SampleDataUtil.java # src/main/java/seedu/address/storage/JsonAdaptedStudent.java # src/main/java/seedu/address/ui/StudentCard.java # src/test/data/JsonSerializableTutorsPetTest/duplicateStudentTutorsPet.json # src/test/data/JsonSerializableTutorsPetTest/typicalStudentsTutorsPet.json # src/test/java/seedu/address/logic/LogicManagerTest.java # src/test/java/seedu/address/logic/commands/CommandTestUtil.java # src/test/java/seedu/address/logic/commands/EditStudentDescriptorTest.java # src/test/java/seedu/address/logic/parser/AddCommandParserTest.java # src/test/java/seedu/address/logic/parser/EditCommandParserTest.java # src/test/java/seedu/address/logic/parser/ParserUtilTest.java # src/test/java/seedu/address/model/AddressBookTest.java # src/test/java/seedu/address/model/person/UniquePersonListTest.java # src/test/java/seedu/address/model/student/AddressTest.java # src/test/java/seedu/address/model/student/NameContainsKeywordsPredicateTest.java # src/test/java/seedu/address/model/student/StudentTest.java # src/test/java/seedu/address/storage/JsonAdaptedStudentTest.java # src/test/java/seedu/address/testutil/EditPersonDescriptorBuilder.java # src/test/java/seedu/address/testutil/PersonBuilder.java # src/test/java/seedu/address/testutil/StudentUtil.java # src/test/java/seedu/address/testutil/TypicalPersons.java
dextertanyj
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
Nice work! LGTM.
Might have to reconsider the wording of certain comments down the road because previously address book could refer to both the name and the purpose of the product, but Tutor's Pet can only refer to the name of our new product.
But to prevent this PR from being a blocker, I think we can roll with the changes made here first.
samlsm
approved these changes
Sep 24, 2020
This was referenced Oct 4, 2020
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.