New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update student related commands #56

Merged

ypinhsuan merged 4 commits into AY2021S1-CS2103T-T10-4:master from ypinhsuan:update-command-for-student

Sep 25, 2020

ypinhsuan commented Sep 24, 2020

Resolves #11

ypinhsuan added 3 commits

September 24, 2020 00:12


          Merge branch 'ypinhsuan-rename-addressbook-person' into master

a05ada9


          Merge branch 'master' of https://github.com/AY2021S1-CS2103T-T10-4/tp …

63fae9c

…into master


          Rename student related commands and parser

2bbd1c8

samlsm approved these changes

View reviewed changes

samlsm left a comment

LGTM! 👍

src/test/java/seedu/address/logic/commands/EditStudentCommandTest.java Outdated

Comment on lines 30 to 31

		* Contains integration tests (interaction with the Model, UndoCommand and RedoCommand) and unit tests for
		* EditStudentCommand.

samlsm Sep 24, 2020

Perhaps it might be good to follow the same format as DeleteStudentCommandTest to be consistent?

Suggested change

      
             * Contains integration tests (interaction with the Model, UndoCommand and RedoCommand) and unit tests for
          
             * EditStudentCommand.
          
             * Contains integration tests (interaction with the Model, UndoCommand and RedoCommand) and unit tests for
          
             * {@code EditStudentCommand}.

src/main/java/seedu/address/logic/commands/ClearStudentCommand.java Outdated

-                  public static final String COMMAND_WORD = "clear";
-                  public static final String MESSAGE_SUCCESS = "Tutor's Pet has been cleared!";
+                  public static final String COMMAND_WORD = "clear-student";
+                  public static final String MESSAGE_SUCCESS = "All students in Tutor's Pet has been cleared!";

samlsm Sep 24, 2020

I like how you specify that clear removes all students!

dextertanyj Sep 25, 2020

Suggested change

      
                public static final String MESSAGE_SUCCESS = "All students in Tutor's Pet has been cleared!";
          
                public static final String MESSAGE_SUCCESS = "All students in Tutor's Pet have been cleared!";

junlong4321 added this to the v1.2 milestone

dextertanyj approved these changes

View reviewed changes

dextertanyj left a comment

Just some minor suggestions in terms of test case naming, otherwise everything else looks good to me!

src/main/java/seedu/address/logic/commands/ClearStudentCommand.java Outdated

-                  public static final String COMMAND_WORD = "clear";
-                  public static final String MESSAGE_SUCCESS = "Tutor's Pet has been cleared!";
+                  public static final String COMMAND_WORD = "clear-student";
+                  public static final String MESSAGE_SUCCESS = "All students in Tutor's Pet has been cleared!";

dextertanyj Sep 25, 2020

Suggested change

      
                public static final String MESSAGE_SUCCESS = "All students in Tutor's Pet has been cleared!";
          
                public static final String MESSAGE_SUCCESS = "All students in Tutor's Pet have been cleared!";

src/test/java/seedu/address/testutil/StudentUtil.java Outdated

@@ @@ -21,7 +21,7 @@ @@
                    * Returns an add command string for adding the {@code student}.
                    */
                   public static String getAddCommand(Student student) {

dextertanyj Sep 25, 2020

Perhaps we can rename this to getAddStudentCommand(Student student)

src/test/java/seedu/address/logic/parser/TutorsPetParserTest.java Outdated

    
                      assertEquals(new DeleteCommand(INDEX_FIRST_STUDENT), command);

                      DeleteStudentCommand command = (DeleteStudentCommand) parser.parseCommand(

                              DeleteStudentCommand.COMMAND_WORD + " " + INDEX_FIRST_STUDENT.getOneBased());

                      assertEquals(new DeleteStudentCommand(INDEX_FIRST_STUDENT), command);

                  }

                  @Test

                  public void parseCommand_edit() throws Exception {

dextertanyj Sep 25, 2020

Suggested change

      
                public void parseCommand_edit() throws Exception {
          
                public void parseCommand_editStudent() throws Exception {

src/test/java/seedu/address/logic/parser/TutorsPetParserTest.java Outdated

-                      assertTrue(parser.parseCommand(ClearCommand.COMMAND_WORD) instanceof ClearCommand);
-                      assertTrue(parser.parseCommand(ClearCommand.COMMAND_WORD + " 3") instanceof ClearCommand);
+                      assertTrue(parser.parseCommand(ClearStudentCommand.COMMAND_WORD) instanceof ClearStudentCommand);
+                      assertTrue(parser.parseCommand(ClearStudentCommand.COMMAND_WORD + " 3") instanceof ClearStudentCommand);
                   }
                   @Test
                   public void parseCommand_delete() throws Exception {

dextertanyj Sep 25, 2020

Suggested change

      
                public void parseCommand_delete() throws Exception {
          
                public void parseCommand_deleteStudent() throws Exception {

src/test/java/seedu/address/logic/parser/TutorsPetParserTest.java Outdated

		@@ -36,30 +36,30 @@
		@Test
		public void parseCommand_add() throws Exception {

dextertanyj Sep 25, 2020

Suggested change

      
                public void parseCommand_add() throws Exception {
          
                public void parseCommand_addStudent() throws Exception {

src/test/java/seedu/address/logic/parser/TutorsPetParserTest.java Outdated

-                      AddCommand command = (AddCommand) parser.parseCommand(StudentUtil.getAddCommand(student));
-                      assertEquals(new AddCommand(student), command);
+                      AddStudentCommand command = (AddStudentCommand) parser.parseCommand(StudentUtil.getAddCommand(student));
+                      assertEquals(new AddStudentCommand(student), command);
                   }
                   @Test
                   public void parseCommand_clear() throws Exception {

dextertanyj Sep 25, 2020

Suggested change

      
                public void parseCommand_clear() throws Exception {
          
                public void parseCommand_clearStudent() throws Exception {

src/test/java/seedu/address/logic/parser/TutorsPetParserTest.java Outdated

		@@ -71,9 +71,9 @@ public void parseCommand_exit() throws Exception {
		@Test
		public void parseCommand_find() throws Exception {

dextertanyj Sep 25, 2020

Suggested change

      
                public void parseCommand_find() throws Exception {
          
                public void parseCommand_findStudent() throws Exception {

src/test/java/seedu/address/logic/parser/FindStudentCommandParserTest.java Outdated

                   @Test
                   public void parse_emptyArg_throwsParseException() {
-                      assertParseFailure(parser, "     ", String.format(MESSAGE_INVALID_COMMAND_FORMAT, FindCommand.MESSAGE_USAGE));
+                      assertParseFailure(parser, "     ", String.format(MESSAGE_INVALID_COMMAND_FORMAT,
+                              FindStudentCommand.MESSAGE_USAGE));
                   }
                   @Test
                   public void parse_validArgs_returnsFindCommand() {

dextertanyj Sep 25, 2020

Suggested change

      
                public void parse_validArgs_returnsFindCommand() {
          
                public void parse_validArgs_returnsFindStudentCommand() {

src/test/java/seedu/address/logic/parser/DeleteStudentCommandParserTest.java Outdated

-                  private DeleteCommandParser parser = new DeleteCommandParser();
+                  private DeleteStudentCommandParser parser = new DeleteStudentCommandParser();
                   @Test
                   public void parse_validArgs_returnsDeleteCommand() {

dextertanyj Sep 25, 2020

Suggested change

      
                public void parse_validArgs_returnsDeleteCommand() {
          
                public void parse_validArgs_returnsDeleteStudentCommand() {


          Rename test cases

713496e

ypinhsuan merged commit 8df9335 into AY2021S1-CS2103T-T10-4:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment