Refactor name component #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dextertanyj
requested review from
a team,
ypinhsuan and
samlsm
and removed request for
a team
ypinhsuan
approved these changes
Sep 28, 2020
src/test/java/seedu/address/model/components/name/NameContainsKeywordsPredicateTest.java
Outdated
Show resolved
Hide resolved
samlsm
reviewed
Sep 29, 2020
samlsm
approved these changes
Sep 29, 2020
src/test/java/seedu/address/model/components/name/NameContainsKeywordsPredicateTest.java
Outdated
Show resolved
Hide resolved
dextertanyj
force-pushed
the
refactor-name-component
branch
from
4f3561d
to
09c139e
Compare
dextertanyj
force-pushed
the
refactor-name-component
branch
from
09c139e
to
5c5bdee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
Namecomponent to reduce code duplication.Also reorganised
tagpackage intocomponentspackage.