Implement link command #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dextertanyj
requested review from
a team,
ypinhsuan and
samlsm
and removed request for
a team
samlsm
approved these changes
Sep 30, 2020
Comment on lines
+49
to
+54
| // manually link first class to first student | ||
| ModuleClass moduleClass = model.getFilteredModuleClassList().get(0); | ||
| Student student = model.getFilteredStudentList().get(0); | ||
| Set<UUID> studentUuids = new HashSet<>(moduleClass.getStudentUuids()); | ||
| studentUuids.add(student.getUuid()); | ||
| ModuleClass modifiedModuleClass = new ModuleClass(moduleClass.getName(), studentUuids); |
There was a problem hiding this comment.
would it be better to leave a line here?
Suggested change
| // manually link first class to first student | |
| ModuleClass moduleClass = model.getFilteredModuleClassList().get(0); | |
| Student student = model.getFilteredStudentList().get(0); | |
| Set<UUID> studentUuids = new HashSet<>(moduleClass.getStudentUuids()); | |
| studentUuids.add(student.getUuid()); | |
| ModuleClass modifiedModuleClass = new ModuleClass(moduleClass.getName(), studentUuids); | |
| // manually link first class to first student | |
| ModuleClass moduleClass = model.getFilteredModuleClassList().get(0); | |
| Student student = model.getFilteredStudentList().get(0); | |
| Set<UUID> studentUuids = new HashSet<>(moduleClass.getStudentUuids()); | |
| studentUuids.add(student.getUuid()); | |
| ModuleClass modifiedModuleClass = new ModuleClass(moduleClass.getName(), studentUuids); |
There was a problem hiding this comment.
I think for this case, it would be okay to not include an empty line above the comment since it is the first line in the method body. It will also be more in line with existing code.
dextertanyj
force-pushed
the
link-command
branch
from
7bcf0c1
to
6be4032
Compare
dextertanyj
force-pushed
the
link-command
branch
from
6be4032
to
58e135b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #86.
Closes #28.