Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update list command #93

Merged
merged 5 commits into from
Sep 30, 2020
Merged

Update list command #93

merged 5 commits into from
Sep 30, 2020

Conversation

ypinhsuan
Copy link

Resolves #74

@ypinhsuan ypinhsuan added this to the v1.2-extended milestone Sep 30, 2020
@ypinhsuan ypinhsuan requested review from a team, samlsm and junlong4321 and removed request for a team September 30, 2020 12:55
junlong4321
junlong4321 approved these changes Sep 30, 2020
View reviewed changes
Copy link

@junlong4321 junlong4321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes. Otherwise LGTM

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
src/main/java/seedu/address/logic/parser/TutorsPetParser.java Outdated Show resolved Hide resolved
src/test/java/seedu/address/logic/parser/TutorsPetParserTest.java Outdated
@Test
public void parseCommand_list() throws Exception {
assertTrue(parser.parseCommand(ListCommand.COMMAND_WORD) instanceof ListCommand);
assertTrue(parser.parseCommand(ListCommand.COMMAND_WORD + " 3") instanceof ListCommand);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"3" seems like a magic number across the test script. We might want to consider abstracting it into a variable in a separate PR

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with this

samlsm
samlsm approved these changes Sep 30, 2020
View reviewed changes
Copy link

@samlsm samlsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 It would be great if you can help organize the layout of the table like what Jun Long commented:)
Also, perhaps we can remove the [coming soon] label at line 167 of the user guide?

@ypinhsuan ypinhsuan merged commit 00a3586 into AY2021S1-CS2103T-T10-4:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlsm samlsm samlsm approved these changes

@junlong4321 junlong4321 junlong4321 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2-extended
Development

Successfully merging this pull request may close these issues.

Update list functionality to show all students and classes
3 participants
@ypinhsuan @samlsm @junlong4321