Enhance Sales Functionality #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation meant editing the UniqueSaleList belonging to the specified person, which does not preserve the immutability. This new implementation clones the person and adds the sale to the new person, thereby preserving immutability.
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
============================================
+ Coverage 71.31% 73.75% +2.44%
- Complexity 837 877 +40
============================================
Files 132 132
Lines 2698 2774 +76
Branches 335 345 +10
============================================
+ Hits 1924 2046 +122
+ Misses 658 615 -43
+ Partials 116 113 -3
Continue to review full report at Codecov.
|
jmleong666
reviewed
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102, closes #103, closes #104
In this PR, I have done the following:
In addition, I have also changed the implementation of AddCommand and DeleteCommand. Previously, they added the sale directly to the contact. However, it now creates a deep copy of the person, which is edited and placed into the list. This preserves the immutability of the Person object.