Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contact ID #128

Merged
merged 9 commits into from
Oct 21, 2020
Merged

Fix contact ID #128

merged 9 commits into from
Oct 21, 2020

Conversation

hakujitsu
Copy link

@hakujitsu hakujitsu commented Oct 20, 2020 •
edited

This PR aims to fix the implementation of a contact index.

  • Current contact ID is now a variable that will be initialised upon startup
  • When AddCommand is executed, it will get the current contact ID from Model, and calculate the next contact id by incrementing it by 1.
  • The AddPerson method in ModelManager will increment the current contact ID after successful addition of the person to the list.

@hakujitsu hakujitsu marked this pull request as ready for review October 21, 2020 09:15
AaronnSeah
AaronnSeah reviewed Oct 21, 2020
View reviewed changes
Copy link

@AaronnSeah AaronnSeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will leave approving review to Jin ming.

src/main/java/seedu/address/model/ModelManager.java Outdated Show resolved Hide resolved
jmleong666
jmleong666 approved these changes Oct 21, 2020
View reviewed changes
Copy link

@jmleong666 jmleong666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmleong666 jmleong666 merged commit 2ff256c into AY2021S1-CS2103T-T11-1:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronnSeah AaronnSeah AaronnSeah left review comments

@jmleong666 jmleong666 jmleong666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hakujitsu @AaronnSeah @jmleong666