Implement user input history #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronnSeah
approved these changes
Oct 21, 2020
| /** | ||
| * Handles the Enter button pressed event. | ||
| */ | ||
| @FXML | ||
| private void handleCommandEntered() { | ||
| userInputHistory.addToHistory(commandTextField.getText()); | ||
| try { |
There was a problem hiding this comment.
you might want to consider only adding the text if its not blank?
There was a problem hiding this comment.
Yeah should've considered that earlier.
| @@ -0,0 +1,54 @@ | |||
| package seedu.address.ui; | |||
There was a problem hiding this comment.
will unit tests be added in future PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #132.
New features/changes
Implementations
UserInputHistoryto store all user inputs within the session. User inputs are stored in aLinkedList, and itsListIteratoris used to navigate between inputs. Whenever the user enters a command, add the input to theuserInputHistoryof the command box and reset its iterator.Possible improvements
ListIteratornavigation logic).Testing
UserInputHistoryclass.Demo
