-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to edit meetings and prevent conflicting meetings #148
Add command to edit meetings and prevent conflicting meetings #148
Conversation
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
============================================
+ Coverage 74.30% 74.72% +0.42%
- Complexity 1163 1201 +38
============================================
Files 164 166 +2
Lines 3709 3846 +137
Branches 508 537 +29
============================================
+ Hits 2756 2874 +118
- Misses 775 784 +9
- Partials 178 188 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides the minor things pointed out!
Just an idea, I think it would be helpful to print the conflicting meeting to the user when the error is thrown!
src/main/java/seedu/address/logic/commands/meeting/EditCommand.java
Outdated
Show resolved
Hide resolved
Makes sense. Thanks for the suggestion, I've included the above! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging now!
Closes #109, closes #111
Changes:
meeting edit INDEX [c/CONTACT_INDEX] [m/MESSAGE] [d/DATETIME] [du/DURATION]
meeting edit
andreminder edit
meeting edit
Demo of meeting edit:
Demo of conflicting meetings: